Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0-rc1] [mono][debugger] Fix watch of local variable values #57787

Merged
merged 4 commits into from
Aug 20, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 19, 2021

Backport of #57771 to release/6.0-rc1

/cc @thaystg

Customer Impact

Fixes dotnet/android#6161

Testing

Added a test case for newer protocol versions and manually tested for android (older protocol version).

Risk

It's using an old code for older protocol versions. No risk.

@ghost
Copy link

ghost commented Aug 19, 2021

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #57771 to release/6.0-rc1

/cc @thaystg

Customer Impact

Testing

Risk

Author: github-actions[bot]
Assignees: -
Labels:

area-Debugger-mono

Milestone: -

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Please get a code review and we can request consideration for RC1.

@jeffschwMSFT jeffschwMSFT added the Servicing-consider Issue for next servicing release review label Aug 19, 2021
@jeffschwMSFT jeffschwMSFT added this to the 6.0.0 milestone Aug 19, 2021
@thaystg thaystg requested a review from lewing August 19, 2021 22:52
@lewing lewing added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Aug 20, 2021
@lewing
Copy link
Member

lewing commented Aug 20, 2021

approved in email

@ericstj ericstj merged commit f288bb2 into release/6.0-rc1 Aug 20, 2021
@lewing lewing deleted the backport/pr-57771-to-release/6.0-rc1 branch August 20, 2021 20:26
@ghost ghost locked as resolved and limited conversation to collaborators Sep 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Debugger-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants