-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean-up duplicated PathInternal files #57988
Conversation
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsThere were files named This PR removes duplicity by deleting/moving the files in Common to the other folder.
|
@@ -11,7 +11,7 @@ | |||
<Compile Include="System\IO\Compression\ZipFileExtensions.ZipArchive.Create.cs" /> | |||
<Compile Include="System\IO\Compression\ZipFileExtensions.ZipArchive.Extract.cs" /> | |||
<Compile Include="System\IO\Compression\ZipFileExtensions.ZipArchiveEntry.Extract.cs" /> | |||
<Compile Include="$(CommonPath)System\IO\PathInternal.CaseSensitivity.cs" | |||
<Compile Include="$(CoreLibSharedDir)System\IO\PathInternal.CaseSensitivity.cs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would "$(CommonPath)System\IO\PathInternal.*
be more appropriate place for these files?
These files do not contain public APIs. I think we only use CoreLib includes for files with public APIs, and only include them for legacy TFM configurations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think Jan's suggestion makes sense to move the file to the other location.
We also wanted to merge the |
Yes, separate; but I think that's a broader issue that not just affects System.IO space. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last commit LGTM.
There were files named
PathInternal*.cs
under thelibraries/Common/src/System/IO folder
, while at the same time we havePathInternal*.cs
files underlibraries/System.Private.CoreLib/src/System/IO
, the content in both files was more or less identical.This PR removes duplicity by deleting/moving the files in Common to the other folder.