[release/6.0] Add System.Net.Http ServerCertificateCustomValidationCallback ILLink Suppression #58508
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…ck ILLink Suppression
|
Tagging subscribers to this area: @dotnet/ncl |
|
Tagging subscribers to 'arch-android': @steveisok, @akoeplinger Issue DetailsBackport of #58456 to release/6.0 Fixes #57537 During PR #57555, it was unclear what the correct suppression syntax would be for a return type of /cc @mdh1418 Customer ImpactWhen supporting either using the native Removes PNSE from Without this PR, TestingRiskLow, this PR will reenable
|
|
@mdh1418 this needs more work to fix the build |
They're 99% identical so we can just use one .cs file with ifdefs instead. This reduces the chance of missing one of the files when a new method is added.
|
is this ready now? |
ghost
locked as resolved and limited conversation to collaborators
Backport of #58456 to release/6.0
Fixes #57537
During PR #57555, it was unclear what the correct suppression syntax would be for a return type of
Func<HttpRequestMessage, X509Certificate2?, X509Chain?, SslPolicyErrors, bool>. With some helpful switches to generate the right warning suppression syntax via--generate-warning-suppressions xmlinRuntimePackILLinkArgs, this PR adds the correct warning suppression./cc @mdh1418
Customer Impact
When supporting either using the native
HttpMessageHandlertypes in Xamarin orSocketsHttpHandleras the underlying handler inHttpClientHandler, some APIs such asServerCertificateCustomValidationCallbackhad thrown PNSE when the native handler was enabled. It didn't make sense to always throw PNSE, and a majority of the methods were modified to suppress ILLink error messages except forServerCertificateCustomValidationCallbackbecause of its return type.Removes PNSE from
ServerCertificateCustomValidationCallbackAdds ILLink error message suppression for
ServerCertificateCustomValidationCallbackWithout this PR,
ServerCertificateCustomValidationCallbackwill continue to throw PNSE.Testing
Risk
Low, this PR will reenable
ServerCertificateCustomValidationCallbackinstead of throwingArg_PlatformNotSupportedexception.