[libraries] Restrict ILLink Suppression xml to mobile platforms #58519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
linkable-framework
|
Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr Issue DetailsFollow up to https://github.com/dotnet/runtime/pull/58456/files#r700368913
|
eerhardt
reviewed
Sep 2, 2021
| @@ -30,7 +30,7 @@ | |||
| <_RuntimePackSuppressionsXmls Include="$(ILLinkTrimAssemblyRuntimePackSuppressionsXmlsDir)*.xml" /> | |||
|
|
|||
| <!-- Collate CoreLib suppression XML files not bin-placed in earlier per-library linker run. CoreLib doesn't use bin-place logic. --> | |||
| <_RuntimePackSuppressionsXmls Include="$(CoreLibSharedDir)ILLink\ILLink.Suppressions.LibraryBuild.xml" /> | |||
| <_RuntimePackSuppressionsXmls Condition="'$(TargetsMobile)' == 'true'" Include="$(CoreLibSharedDir)ILLink\ILLink.Suppressions.LibraryBuild.xml" /> | |||
There was a problem hiding this comment.
This isn't going to work. This line is for CoreLib, but the file in question is for System.Net.Http.
My thinking was to rename https://github.com/dotnet/runtime/blob/main/src/libraries/System.Net.Http/src/ILLink/ILLink.Suppressions.LibraryBuild.xml to https://github.com/dotnet/runtime/blob/main/src/libraries/System.Net.Http/src/ILLink/ILLink.Suppressions.Mobile.LibraryBuild.xml
And then in System.Net.Http/src/System.Net.Http.csproj add:
<ItemGroup>
<ILLinkSuppressionsXmls Condition="'$(TargetsMobile)' == 'true'" Include="$(ILLinkDirectory)ILLink.Suppressions.Mobile.LibraryBuild.xml" />
marek-safar
approved these changes
Sep 6, 2021
marek-safar
deleted the
condition_xml_suppression_system_net_http_to_mobile_only
branch
mdh1418
added a commit
to mdh1418/runtime
that referenced
this pull request
Sep 9, 2021
…et#58519) Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>
steveisok
pushed a commit
that referenced
this pull request
Sep 13, 2021
…t and test fixes for Android (#58841) Manual backport of #57208, #58519, #58562, #58210, #57732, #58428, #58586, #58745, #57687 to release/6.0 Numerous test suites have been failing for iOS/tvOS/MacCatalyst consistently on CI without useful logs as to why. Moreover, some of these suites pass locally. This PR looks to reduce the failures on CI by skipping the problematic suites Skips test suites logged in #53624 ActiveIssues #58440 #58418 #58367 #58584 Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com> Co-authored-by: Jo Shields <directhex@apebox.org>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to https://github.com/dotnet/runtime/pull/58456/files#r700368913