Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the implementation of Win32Exception into System.Private.CoreLib #58529

Merged
1 commit merged into from
Sep 2, 2021

Conversation

jkoritzinsky
Copy link
Member

Required for #57610

@ghost
Copy link

ghost commented Sep 2, 2021

Hello @jkoritzinsky!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 441271c into dotnet:main Sep 2, 2021
@stephentoub
Copy link
Member

Should we consider introducing a exception type named better? We could move all the logic from Win32Exception into it and make Win32Exception derive from it. It's just such unfortunate naming. We've accepted that for existing code, but it seems nice to avoid using it in more places.

@jkotas
Copy link
Member

jkotas commented Sep 2, 2021

The discussion about that is in #26227. I agree that it would be nice to do something about this unfortunate name.

@stephentoub
Copy link
Member

Right. That discussion is primarily about existing code, though, and how to deal with compatibility. It looks like we're moving the exception type to corelib to enable new uses, such that brand new APIs throw this; I'm suggesting we take this opportunity to move ahead on something that can be used with new APIs before we increase the proliferation of "Win32" things in cross-platform code.

@jkoritzinsky jkoritzinsky deleted the Win32Exception-corelib branch September 2, 2021 15:36
@ghost ghost locked as resolved and limited conversation to collaborators Oct 2, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants