add W11 test queue #58570

wfurt · 2021-09-02T16:49:14Z

replaces #55298
Contributes to #55639
Contributes to #58587

ghost · 2021-09-02T17:05:09Z

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

replaces #55298
contributes to #55639

Author:	wfurt
Assignees:	wfurt
Labels:	`area-Infrastructure`
Milestone:	-

wfurt · 2021-09-02T20:59:27Z

We don't get individual tests but Quic had 547 test runs so it looks like MsQuic is in.

C:\h\w\9B9D08E2\w\A2950951\e>"C:\h\w\9B9D08E2\p\dotnet.exe" exec --runtimeconfig System.Net.Quic.Functional.Tests.runtimeconfig.json --depsfile System.Net.Quic.Functional.Tests.deps.json xunit.console.dll System.Net.Quic.Functional.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing  
  Discovering: System.Net.Quic.Functional.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Net.Quic.Functional.Tests (found 140 of 150 test cases)
  Starting:    System.Net.Quic.Functional.Tests (parallel test collections = on, max threads = 2)
  Finished:    System.Net.Quic.Functional.Tests
=== TEST EXECUTION SUMMARY ===
   System.Net.Quic.Functional.Tests  Total: 547, Errors: 0, Failed: 0, Skipped: 0, Time: 60.849s

https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-58570-merge-71d5888539224bb281/System.Net.Quic.Functional.Tests/1/console.817b7652.log?sv=2019-07-07&se=2021-09-22T18%3A25%3A20Z&sr=c&sp=rl&sig=ZUf%2BvlsRaiZhT8qXiJFDFL%2FkE%2BjPMYjAMKnuOtaIDiM%3D

WinHttp tests are failing on Windows 11. Opened #58587 to track it.

ManickaP

Thanks!

ViktorHofer · 2021-09-03T08:25:53Z

cc @aik-jahoda as he is updating the test matrix.

karelz · 2021-09-03T12:34:38Z

Looks like there are Win11-specific problems:

System.Net.Http.Functional.Tests.PlatformHandler_HttpClientHandler_SslProtocols_Test.GetAsync_AllowedSSLVersion_Succeeds - failed all 4 combinations of the test - see log
Sockets timed out 5 tests in SendPacketsAsync - see log:
- SendPacketsElement_FileStreamMultiPartMixed_MultipleFileStreams_Success
- SendPacketsElement_FileStreamLargeOffset_Throws
- SendPacketsElement_FileStreamWithOptions_Success
- SendPacketsElement_FileZeroCount_Success
- SendPacketsElement_FileLargeOffset_Throws

danmoseley · 2021-09-09T02:43:17Z

eng/pipelines/libraries/helix-queues-setup.yml

@@ -141,6 +141,7 @@ jobs:
          - ${{ if ne(parameters.jobParameters.isFullMatrix, true) }}:
            - Windows.81.Amd64.Open
            - Windows.10.Amd64.Server19H1.ES.Open
+            - Windows.11.Amd64.ClientPre.Open


Cc @aik-jahoda

danmoseley · 2021-09-09T02:43:55Z

src/libraries/Common/tests/TestUtilities/System/PlatformDetection.Windows.cs

@@ -57,6 +57,9 @@ public static partial class PlatformDetection

        public static bool IsWindows10Version2004Build19573OrGreater => IsWindowsVersionOrLater(10, 0, 19573);

+        // Windows 11 aka 21H2


Should this be just "IsWindows11OrLater" then?

danmoseley · 2021-09-09T02:47:27Z

iOS build timed out. Hard to imagine how it could be related.

wfurt · 2021-09-09T16:30:49Z

Do we want to take this for 6.0 @danmoseley?

ViktorHofer · 2021-09-09T16:42:20Z

Yes we want this for 6.0 but I'm wondering if we want to backport all the queue changes together or separately? cc @aik-jahoda

wfurt · 2021-09-09T17:15:31Z

I don't know what is better. I started separately and end-up lumping other changes in as it was easier to verify that everything actually works.

karelz · 2021-09-09T17:50:59Z

Given that this also enables WinHttpHandler to work correctly on Win11 (product change), I would like to get it into 6.0 RC2.
Is there any reason for NOT porting Win11 queue to 6.0 right now? (in which case we should separately port the WinHttpHandler product change needed)

ViktorHofer · 2021-09-09T18:01:59Z

Didn't know about the product change. In that case we should definitely get this in asap. @aik-jahoda is currently taking care of updating our queues to not run on EOL ones and test the ones that we actually support with .NET 6 and I expect that there will be more to backport (hopefully none product changes but who knows).

wfurt · 2021-09-09T18:22:04Z

Technically speaking, we can cut it out. But it was easier to fix the product than the tests - at least for main.
Win11 is first Windows OS where Tls13 is officially supported. So the gap did not matter until now.

am11 · 2021-09-09T18:22:09Z

Sockets timed out 5 tests in SendPacketsAsync - see log:

These are still failing in other PRs, e.g. a recent console log. Is there any issue tracking it or should I open one?

wfurt · 2021-09-09T18:24:54Z

Seems like flaky tests. Open issue @am11 if you see failures. @karelz is running some reports from test database so we should see it eventually.

am11 · 2021-09-09T18:46:46Z

#58898

wfurt · 2021-09-09T18:48:53Z

thanks. BTW I did run all the sockets tests locally and they seems ok. So far there is no indication this is product issue - more likely test problem. I know we run on v2 virtual HW and the timing may be different.

danmoseley · 2021-09-09T19:12:50Z

Looks like q was already answered above, but yes we need the Win11 queue in 6.0, and probably much or possibly all of the other coverage adjustments @aik-jahoda is doing. Could be separately.

aik-jahoda · 2021-09-13T06:53:38Z

Summary: backport this PR to release/6, is that correct and later merge rest of the CI matrix. @danmoseley is that correct?

aik-jahoda · 2021-09-13T07:26:22Z

There is rest of Windows related CI matrix change: #58989

aik-jahoda · 2021-09-15T14:11:19Z

/backport to release/6.0

github-actions · 2021-09-15T14:11:34Z

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1237958281

safern

LGTM

add W11 test queue

c90dfb8

wfurt added the area-Infrastructure label Sep 2, 2021

wfurt requested review from ViktorHofer and a team September 2, 2021 16:49

wfurt self-assigned this Sep 2, 2021

move to release config

a8771ac

wfurt mentioned this pull request Sep 2, 2021

add TLS 1.3 support to WinHttp #58590

Merged

ManickaP approved these changes Sep 3, 2021

View reviewed changes

wfurt added 2 commits September 3, 2021 19:24

Merge branch 'main' of https://github.com/dotnet/runtime into Win10

927f482

move to x66

d812c84

karelz mentioned this pull request Sep 6, 2021

Test failure: GetAsync_AllowedSSLVersion_Succeeds #57343

Closed

wfurt added 3 commits September 8, 2021 10:52

fix tls13 detection

af0916c

Merge branch 'main' of https://github.com/dotnet/runtime into Win11

82f8b3a

disable failing EventLog tests

2537add

wfurt mentioned this pull request Sep 8, 2021

EventLog tests failing on Windows 11 and Windows Server 2022 #58829

Open

danmoseley approved these changes Sep 9, 2021

View reviewed changes

danmoseley merged commit c515c50 into dotnet:main Sep 9, 2021

am11 mentioned this pull request Sep 9, 2021

Add delete operator in Crst class #58885

Merged

github-actions bot mentioned this pull request Sep 15, 2021

[release/6.0] fix TLS 1.3 in WinHttpHandler #59159

Merged

karelz mentioned this pull request Sep 15, 2021

WinHttp tests with Tls 1.3 are failing #58587

Closed

safern reviewed Sep 20, 2021

View reviewed changes

ghost locked as resolved and limited conversation to collaborators Nov 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add W11 test queue #58570

add W11 test queue #58570

wfurt commented Sep 2, 2021 •

edited by karelz

Loading

ghost commented Sep 2, 2021

wfurt commented Sep 2, 2021 •

edited

Loading

ManickaP left a comment

ViktorHofer commented Sep 3, 2021

karelz commented Sep 3, 2021

danmoseley Sep 9, 2021

danmoseley Sep 9, 2021

danmoseley commented Sep 9, 2021

wfurt commented Sep 9, 2021

ViktorHofer commented Sep 9, 2021

wfurt commented Sep 9, 2021

karelz commented Sep 9, 2021 •

edited

Loading

ViktorHofer commented Sep 9, 2021

wfurt commented Sep 9, 2021

am11 commented Sep 9, 2021

wfurt commented Sep 9, 2021

am11 commented Sep 9, 2021

wfurt commented Sep 9, 2021

danmoseley commented Sep 9, 2021

aik-jahoda commented Sep 13, 2021

aik-jahoda commented Sep 13, 2021

aik-jahoda commented Sep 15, 2021

github-actions bot commented Sep 15, 2021

safern left a comment

		@@ -57,6 +57,9 @@ public static partial class PlatformDetection

		public static bool IsWindows10Version2004Build19573OrGreater => IsWindowsVersionOrLater(10, 0, 19573);

		// Windows 11 aka 21H2

add W11 test queue #58570

add W11 test queue #58570

Conversation

wfurt commented Sep 2, 2021 • edited by karelz Loading

ghost commented Sep 2, 2021

wfurt commented Sep 2, 2021 • edited Loading

ManickaP left a comment

Choose a reason for hiding this comment

ViktorHofer commented Sep 3, 2021

karelz commented Sep 3, 2021

danmoseley Sep 9, 2021

Choose a reason for hiding this comment

danmoseley Sep 9, 2021

Choose a reason for hiding this comment

danmoseley commented Sep 9, 2021

wfurt commented Sep 9, 2021

ViktorHofer commented Sep 9, 2021

wfurt commented Sep 9, 2021

karelz commented Sep 9, 2021 • edited Loading

ViktorHofer commented Sep 9, 2021

wfurt commented Sep 9, 2021

am11 commented Sep 9, 2021

wfurt commented Sep 9, 2021

am11 commented Sep 9, 2021

wfurt commented Sep 9, 2021

danmoseley commented Sep 9, 2021

aik-jahoda commented Sep 13, 2021

aik-jahoda commented Sep 13, 2021

aik-jahoda commented Sep 15, 2021

github-actions bot commented Sep 15, 2021

safern left a comment

Choose a reason for hiding this comment

wfurt commented Sep 2, 2021 •

edited by karelz

Loading

wfurt commented Sep 2, 2021 •

edited

Loading

karelz commented Sep 9, 2021 •

edited

Loading