JIT: relax assert in lvaSetDoNotEnregister #58597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If user code reinterprets a non-struct local as a struct (say via `Unsafe.As`) at a call site, then we may see `DNER_IsStructArg` ussed for that local. Remove an assert and update the descriptive text. Fixes #58515.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsIf user code reinterprets a non-struct local as a struct (say via Fixes #58515.
|
|
cc @dotnet/jit-contrib |
EgorBo
approved these changes
Sep 4, 2021
|
CI failure is #11063. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user code reinterprets a non-struct local as a struct (say via
Unsafe.As)at a call site, then we may see
DNER_IsStructArgused for that local. Removean assert and update the descriptive text.
Fixes #58518.