Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tvOS] Be less eager in creating the non-existent special folders #58788

Merged
merged 1 commit into from
Sep 13, 2021
Merged

[tvOS] Be less eager in creating the non-existent special folders #58788

merged 1 commit into from
Sep 13, 2021

Conversation

filipnavara
Copy link
Member

Fixes #58787

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 8, 2021
@ghost
Copy link

ghost commented Sep 8, 2021

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #58787

Author: filipnavara
Assignees: -
Labels:

area-System.IO
Milestone: -

@marek-safar marek-safar added the os-tvos Apple tvOS label Sep 8, 2021
@steveisok steveisok self-requested a review September 9, 2021 15:41
steveisok
steveisok approved these changes Sep 9, 2021
View reviewed changes
Copy link
Member

@steveisok steveisok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The catalyst failure appears to be a flake in startup and is unrelated.

@marek-safar
Copy link
Contributor

/backport to release/6.0

@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1228799779

@github-actions github-actions bot mentioned this pull request Sep 13, 2021
Merged
@steveisok steveisok merged commit fa28488 into dotnet:main Sep 13, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@directhex directhex directhex approved these changes

@steveisok steveisok steveisok approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

Assignees
No one assigned
Labels
area-System.Runtime community-contribution Indicates that the PR has been added by a community member os-tvos Apple tvOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tvOS] Environment.GetSpecialFolder is too eager in creating the special directories
5 participants
@filipnavara @marek-safar @directhex @steveisok @danmoseley