Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP2 loopback server WaitForCancellationAsync should validate error code sent #59313

Merged
merged 3 commits into from
Nov 2, 2021
Merged

HTTP2 loopback server WaitForCancellationAsync should validate error code sent #59313

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca870aa
HTTP2 loopback server WaitForCancellationAsync should validate error …
pedrobsaila Sep 19, 2021
903fae6
replace constant with enum
pedrobsaila Sep 19, 2021
d124c25
fix remarks 2
pedrobsaila Sep 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/Common/tests/System/Net/Http/Http2LoopbackConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -973,7 +973,7 @@ public override async Task WaitForCancellationAsync(bool ignoreIncomingData = tr
{
Assert.Equal(FrameType.RstStream, frame.Type);
}
} while (frame.Type != FrameType.RstStream);
} while (frame.Type != FrameType.RstStream || (frame is RstStreamFrame rstStreamFrame && rstStreamFrame.ErrorCode != 0x8));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
} while (frame.Type != FrameType.RstStream || (frame is RstStreamFrame rstStreamFrame && rstStreamFrame.ErrorCode != 0x8));
} while (frame.Type != FrameType.RstStream || (frame is RstStreamFrame rstStreamFrame && rstStreamFrame.ErrorCode != ProtocolErrors.CANCEL));

I think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ErrorCode property is an int, so I casted the enum


Assert.Equal(streamId, frame.StreamId);
}
Expand Down