Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Enable System.Text.Json.SourceGeneration.Tests #59396

Merged
merged 1 commit into from
Sep 22, 2021
Merged

[wasm] Enable System.Text.Json.SourceGeneration.Tests #59396

merged 1 commit into from
Sep 22, 2021

Conversation

radical
Copy link
Member

@radical radical commented Sep 21, 2021

Fixed by #59352 .

Fixes #59228 .

@ghost
Copy link

ghost commented Sep 21, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixed by #59352 .

Fixes #59228 .

Author: radical
Assignees: -
Labels:

area-System.Net
Milestone: -

@radical radical added arch-wasm WebAssembly architecture disabled-test The test is disabled in source code against the issue labels Sep 21, 2021
@ghost
Copy link

ghost commented Sep 21, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixed by #59352 .

Fixes #59228 .

Author: radical
Assignees: -
Labels:

arch-wasm, area-System.Net, disabled-test
Milestone: -

@ghost
Copy link

ghost commented Sep 22, 2021

Tagging subscribers to this area: @eiriktsarpalis, @layomia
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixed by #59352 .

Fixes #59228 .

Author: radical
Assignees: -
Labels:

arch-wasm, area-System.Text.Json, disabled-test
Milestone: -

layomia
layomia approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@layomia layomia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! FYI @eerhardt @steveharter @ericstj. Seems we should also backport to RC2.

@radical radical merged commit d51400a into dotnet:main Sep 22, 2021
@radical radical deleted the enable-stj branch September 22, 2021 04:36
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@layomia layomia layomia approved these changes

@lewing lewing Awaiting requested review from lewing

@steveisok steveisok Awaiting requested review from steveisok

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-System.Text.Json disabled-test The test is disabled in source code against the issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

System.Text.Json.SourceGeneration.Tests are disabled in WASM
2 participants
@radical @layomia