Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Run AOT, and Wasm.Build.Tests on windows #59479

Merged
merged 34 commits into from
Nov 20, 2021
Merged

[wasm] Run AOT, and Wasm.Build.Tests on windows #59479

merged 34 commits into from
Nov 20, 2021

Conversation

radical
Copy link
Member

@radical radical commented Sep 22, 2021 •
edited
Loading

Adds two new jobs to runtime-staging for Windows - AOT, and Wasm.Build.Tests.

  • AOT - runs with the same conditions as the one in runtime
  • Wasm.Build.Tests - run for rolling builds, or when a narrow set of paths related to wasm build change
    • And do this for corresponding job in runtime for linux

@runfoapp runfoapp bot mentioned this pull request Sep 24, 2021
Closed
@radical radical changed the base branch from release/6.0-rc2 to release/6.0 October 2, 2021 23:35
@lewing lewing modified the milestones: 6.0.1, Future Oct 21, 2021
@radical radical changed the title [IGNORE][wasm] Run wasm aot, wbt tests on windows [wasm] Run wasm aot, wbt tests on windows Nov 7, 2021
@radical radical added the arch-wasm WebAssembly architecture label Nov 7, 2021
@radical radical changed the base branch from release/6.0 to main November 7, 2021 23:45
@ghost
Copy link

ghost commented Nov 7, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono
Milestone: Future

@radical radical changed the title [wasm] Run wasm aot, wbt tests on windows [wasm] Run AOT, and Wasm.Build.Tests on windows Nov 8, 2021
@radical
Copy link
Member Author

radical commented Nov 8, 2021

/azp run runtime,runtime-staging

@azure-pipelines
Copy link

Azure Pipelines failed to run 2 pipeline(s).

@radical radical requested a review from akoeplinger November 15, 2021 07:00
@runfoapp runfoapp bot mentioned this pull request Nov 15, 2021
Closed
@radical radical mentioned this pull request Nov 17, 2021
Open
This was referenced Nov 17, 2021
Closed
Closed
@radical
Copy link
Member Author

radical commented Nov 17, 2021

I have opened an issue for fixing detection of wasm+windows+aot case, and disabling the tests correctly for that - #61720

@radical radical mentioned this pull request Nov 17, 2021
Closed
@radical
Copy link
Member Author

radical commented Nov 17, 2021

The wasm test failure is - #61749

@radical
Copy link
Member Author

radical commented Nov 20, 2021

/azp run runtime-staging-manual

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@radical radical merged commit ce93c29 into dotnet:main Nov 20, 2021
@radical radical deleted the wbt-win-rc2 branch November 20, 2021 01:19
This was referenced Nov 29, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lambdageek lambdageek lambdageek left review comments

@steveisok steveisok steveisok approved these changes

@lewing lewing lewing approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

@pavelsavara pavelsavara Awaiting requested review from pavelsavara

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Milestone
Future
Development

Successfully merging this pull request may close these issues.
6 participants
@radical @pavelsavara @lewing @steveisok @lambdageek @akoeplinger