Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obsolete thumbtacked AssemblyName properties #59522

Merged
merged 8 commits into from
Nov 16, 2021
Merged

Obsolete thumbtacked AssemblyName properties #59522

merged 8 commits into from
Nov 16, 2021

Conversation

i3arnon
Copy link
Contributor

@i3arnon i3arnon commented Sep 23, 2021

Fix #59061

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 23, 2021
@runfoapp runfoapp bot mentioned this pull request Sep 24, 2021
Closed
@buyaa-n
Copy link
Contributor

buyaa-n commented Nov 1, 2021

Ping @i3arnon, could you address the comments?

@jeffhandley jeffhandley self-assigned this Nov 15, 2021
@jeffhandley jeffhandley added the breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. label Nov 15, 2021
@ghost ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Nov 15, 2021
@ghost

This comment has been minimized.

Sign in to view
@jeffhandley jeffhandley mentioned this pull request Nov 15, 2021
Closed
2 tasks
@jeffhandley

This comment has been minimized.

Sign in to view
@jeffhandley jeffhandley removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Nov 15, 2021
buyaa-n
buyaa-n approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jeffhandley jeffhandley merged commit e10532a into dotnet:main Nov 16, 2021
@jeffhandley
Copy link
Member

jeffhandley commented Nov 16, 2021 •
edited
Loading

Thanks for the contribution, @i3arnon! Please feel free to find another up-for-grabs issue if you'd like. 💯

This was referenced Nov 29, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 16, 2021
@i3arnon i3arnon deleted the assembley-name branch January 12, 2022 13:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas left review comments

@buyaa-n buyaa-n buyaa-n approved these changes

@jeffhandley jeffhandley jeffhandley approved these changes

Assignees

@jeffhandley jeffhandley

Labels
area-System.Reflection breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. community-contribution Indicates that the PR has been added by a community member
Projects
No open projects
Triage POD for Reflection, META, etc.
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Obsolete thumbtacked AssemblyName properties
4 participants
@i3arnon @buyaa-n @jeffhandley @jkotas