Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build one MonoTargetsTasks assembly for Microsoft.NET.Runtime.MonoTargets.Sdk pack #59720

Merged
merged 15 commits into from
Sep 30, 2021
Merged

Build one MonoTargetsTasks assembly for Microsoft.NET.Runtime.MonoTargets.Sdk pack #59720

merged 15 commits into from
Sep 30, 2021

Commits on Sep 29, 2021

  1. Build one MonoTargetsTasks assembly for Mono.NET.Runtime.MonoTargets.… 

    …Sdk pack

Instead of 3 assemblies for some tiny tasks.

Building a single assembly also ensures that everything in the pack depends on
and bundles identical versions of dependent assemblies.  For example on net472,
a single version of System.Text.Json with a single fixed version shared by both
the JsonToItemsTaskFactory task factory and the RuntimeConfigParser task.

Related to dotnet#59619
    @lambdageek
    lambdageek committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    802834e View commit details
    Browse the repository at this point in the history

  2. Update testing and wasm to use MonoTargetsTasks.dll

    @lambdageek
    lambdageek committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    9ed921d View commit details
    Browse the repository at this point in the history

  3. FIXME: disable nullability for now

    @lambdageek
    lambdageek committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    4ae1a32 View commit details
    Browse the repository at this point in the history

  4. Move assembly stripper to a separate assembly 

    Build it with nullability checking disabled.

Build the main MonoTargetsTasks assembly with nullability enabled
    @lambdageek
    lambdageek committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    c1a5d6c View commit details
    Browse the repository at this point in the history

  5. Don't include msbuild assemblies in MonoTargets package

    @lambdageek
    lambdageek committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    747d88e View commit details
    Browse the repository at this point in the history

  6. re-enable analyzers for the MonoTargetsTasks assembly

    @lambdageek
    lambdageek committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    290ad79 View commit details
    Browse the repository at this point in the history

  7. Include *.dll in the MonoTargetsTasks nupkg 

    In particular, pick up all the dependent assemblies for the net472 build
    @lambdageek
    lambdageek committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    a0b5e8b View commit details
    Browse the repository at this point in the history

  8. Update various READMEs

    @lambdageek
    lambdageek committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    9953d77 View commit details
    Browse the repository at this point in the history

  9. remove unneeded target

    @lambdageek
    lambdageek committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    2e1d08e View commit details
    Browse the repository at this point in the history

  10. Switch ILStrip to use the same Parallel.ForEach logic as MonoAOTCompiler

    @lambdageek
    lambdageek committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    eb70042 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2021

  1. Remove unneeded NoWarn warnings

    @lambdageek
    lambdageek committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    979e9ac View commit details
    Browse the repository at this point in the history

  2. rearrange package references in MonoTargetsTask.csproj for readabilty

    @lambdageek
    lambdageek committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    8482287 View commit details
    Browse the repository at this point in the history

  3. More ItemGroup reformatting 

    Co-authored-by: Ankit Jain <radical@gmail.com>
    @lambdageek @radical
    lambdageek and radical authored Sep 30, 2021
    Configuration menu
    Copy the full SHA
    9eafb87 View commit details
    Browse the repository at this point in the history

  4. fix nits

    @lambdageek
    lambdageek committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    3d134c8 View commit details
    Browse the repository at this point in the history

  5. Use SystemThreadingTasksExtensionsVersion instead of hardcoding

    @lambdageek
    lambdageek committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    b70035f View commit details
    Browse the repository at this point in the history