Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TimeZones Test failure #60140

Merged
merged 2 commits into from
Oct 7, 2021
Merged

Fix TimeZones Test failure #60140

merged 2 commits into from
Oct 7, 2021

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Oct 7, 2021

Fixes #60119

Recently, Helix started to use Windows 7 N image in the CI run. This image includes a lot of installed UI languages. The time zone display names depends on the installed localized resources on the path %SystemDirectory%\[Language]\tzres.dll.mui. For example, if Japanese UI language is installed, Windows will install the file %SystemDirectory%\ja-JP\tzres.dll.mui. We found on the Windows 7 image, Windows not necessary installing this file for specific language. zh-HK is the one we encountered which caused the test failure.

The fix here is to make the test tolerate this case. The test still working properly and validating all installed UI languages time zone display names.

@ghost
Copy link

ghost commented Oct 7, 2021

Tagging subscribers to this area: @tarekgh, @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #60119

Recently, Helix started to use Windows 7 N image in the CI run. This image includes a lot of installed UI languages. The time zone display names depends on the installed localized resources on the path %SystemDirectory%\[Language]\tzres.dll.mui. For example, if Japanese UI language is installed, Windows will install the file %SystemDirectory%\ja-JP\tzres.dll.mui. We found on the Windows 7 image, Windows not necessary installing this file for specific language. zh-HK is the one we encountered which caused the test failure.

The fix here is to make the test tolerate this case. The test still working properly and validating all installed UI languages time zone display names.

Author: tarekgh
Assignees: -
Labels:

area-System.Globalization
Milestone: -

@ghost
Copy link

ghost commented Oct 7, 2021

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #60119

Recently, Helix started to use Windows 7 N image in the CI run. This image includes a lot of installed UI languages. The time zone display names depends on the installed localized resources on the path %SystemDirectory%\[Language]\tzres.dll.mui. For example, if Japanese UI language is installed, Windows will install the file %SystemDirectory%\ja-JP\tzres.dll.mui. We found on the Windows 7 image, Windows not necessary installing this file for specific language. zh-HK is the one we encountered which caused the test failure.

The fix here is to make the test tolerate this case. The test still working properly and validating all installed UI languages time zone display names.

Author: tarekgh
Assignees: -
Labels:

area-System.Runtime
Milestone: -

@tarekgh tarekgh added this to the 7.0.0 milestone Oct 7, 2021
@tarekgh
Copy link
Member Author

tarekgh commented Oct 7, 2021

CC @MattGal @krwq @safern

safern
safern approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tarekgh
Copy link
Member Author

tarekgh commented Oct 7, 2021

runtime (Libraries Test Run release coreclr windows x86 Debug) failure is unrelated and tracked by the issue #60147

@tarekgh tarekgh merged commit eff8883 into dotnet:main Oct 7, 2021
@tarekgh tarekgh deleted the FixTimeZoneFailingTest branch October 7, 2021 23:28
@tarekgh
Copy link
Member Author

tarekgh commented Oct 7, 2021

/backport to release/6.0

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2021

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1318301449

@github-actions github-actions bot mentioned this pull request Oct 7, 2021
Merged
This was referenced Oct 8, 2021
Merged
Merged
@ericstj ericstj mentioned this pull request Oct 9, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danmoseley danmoseley danmoseley left review comments

@MattGal MattGal MattGal approved these changes

@safern safern safern approved these changes

Assignees
No one assigned
Labels
area-System.DateTime
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

System.Tests.TimeZoneInfoTests.TestWindowsNlsDisplayNames is failing on rolling builds
5 participants
@tarekgh @danmoseley @MattGal @safern @jeffhandley