Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI matrix change: add Windows Server 2022 #60163

Closed
wants to merge 6 commits into from
Closed

CI matrix change: add Windows Server 2022 #60163

wants to merge 6 commits into from

Conversation

aik-jahoda
Copy link
Contributor

@aik-jahoda aik-jahoda commented Oct 8, 2021 •
edited
Loading

OS What to do Notes
Windows Server 2022 Add rolling

part of #57947

This PR changes ssl detection for test for older ssl version

@aik-jahoda aik-jahoda mentioned this pull request Oct 8, 2021
Open
14 tasks
@aik-jahoda aik-jahoda requested a review from wfurt November 25, 2021 13:17
@aik-jahoda
Copy link
Contributor Author

@wfurt, this PR change ssl detection for test. Can you review if this change is reasonable?

@aik-jahoda aik-jahoda requested a review from a team November 29, 2021 14:27
wfurt
wfurt approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detection changes look ok to me. I like the idea of establishing clear default and generalizing the code.

@aik-jahoda
Copy link
Contributor Author

There is hanging quic test: https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-heads-jajahoda-cimatrix206df4d8ed4ac9495a82/System.Net.Quic.Functional.Tests/1/console.6bf2e8e2.log?sv=2019-07-07&se=2021-12-28T18%3A47%3A50Z&sr=c&sp=rl&sig=UyBQWOi2gRIWUKpm8k300kJpLSOtHw2rT769frEFO%2Bg%3D

cc @ManickaP

@ericstj
Copy link
Member

ericstj commented Feb 7, 2022

Looks like this may have been superseded by #64827

@safern @wfurt do we need the PlatofrmDetection changes from this PR? cc @karelz

@safern
Copy link
Member

safern commented Feb 7, 2022

Libraries test runs on Windows on my PR were green, so I'd imagine we no longer need this for some reason? I
ll let @wfurt confirm.

@wfurt
Copy link
Member

wfurt commented Feb 7, 2022

I think the detection part is valuable. There is push to disable Tls1.0 and Tls1.1 on Azure machines. While we dodged it for now (hopefully) that day may come so as other can run into it on their machines.

@safern
Copy link
Member

safern commented Feb 7, 2022

@wfurt would you mind taking care of that?

@safern safern closed this Feb 7, 2022
@wfurt wfurt mentioned this pull request Feb 7, 2022
Merged
@akoeplinger akoeplinger deleted the jajahoda/cimatrix2022 branch February 12, 2022 00:22
@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danmoseley danmoseley danmoseley left review comments

@wfurt wfurt wfurt approved these changes

Assignees
No one assigned
Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aik-jahoda @ericstj @safern @wfurt @danmoseley