Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup workloads for testing logic #60652

Merged
merged 2 commits into from
Oct 20, 2021
Merged

Conversation

safern
Copy link
Member

@safern safern commented Oct 19, 2021

This is intended for testing use only, so I think we should import it on tests.mobile.targets which is only imported in a test project, rather than in all projects under src/libraries.

If people are using this by running /t:Install* they will now need to run it on a test project directly rather than any project.

@ghost
Copy link

ghost commented Oct 19, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

This is intended for testing use only, so I think we should import it on tests.mobile.targets which is only imported in a test project, rather than in all projects under src/libraries.

If people are using this by running /t:Install* they will now need to run it on a test project directly rather than any project.

Author: safern
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@safern safern force-pushed the CleanupWorkloadsTesting branch 2 times, most recently from d17d944 to efb96cd Compare October 19, 2021 22:34
@safern safern force-pushed the CleanupWorkloadsTesting branch from efb96cd to 90cbd05 Compare October 19, 2021 23:18
@safern
Copy link
Member Author

safern commented Oct 20, 2021

I just opened an issue for the DllImportGenerator tests crash: #60705
The other issue is: #60234

@safern safern merged commit 0c080be into dotnet:main Oct 20, 2021
@safern safern deleted the CleanupWorkloadsTesting branch October 20, 2021 23:08
@ghost ghost locked as resolved and limited conversation to collaborators Nov 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants