Properly use result value for dump IPC cmd #60726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @tommcdon Issue Details@lateralusX caught a small error in the dump IPC command error handling while doing some refactoring. Pulling out the fix for that observation into a separate PR for easier backporting. Currently, the dump IPC command will always return "false" even if the dump is successful. This change fixes up the error handling to use the actual error code from creating the dump. CC @tommcdon
|
mikem8361
approved these changes
Oct 21, 2021
am11
reviewed
Oct 21, 2021
|
All creds finding this issue goes to @am11 and @lambdageek, thanks for bringing it to my attention. |
lateralusX
approved these changes
Oct 25, 2021
|
The remaining test failures appear to be #60705. I'll merge today |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lateralusX caught a small error in the dump IPC command error handling while doing some refactoring. Pulling out the fix for that observation into a separate PR for easier backporting.
Currently, the dump IPC command will always return "false" even if the dump is successful. This change fixes up the error handling to use the actual error code from creating the dump.
CC @tommcdon