[release/6.0] Allow nfloat to be in the ObjCRuntime namespace, and make it work for Xamarin.MacCatalyst.dll as well. #60861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
… Xamarin.MacCatalyst.dll as well. Ref: xamarin/xamarin-macios#13092 Ref: mono/mono#21261
github-actions
bot
requested review from
imhameed,
lambdageek,
SamMonoRT and
vargaz
as code owners
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
lambdageek
approved these changes
Oct 26, 2021
rolfbjarne
approved these changes
Oct 26, 2021
mkmibrahim
approved these changes
Oct 27, 2021
|
@marek-safar we weren't able to represent this at tactics today, could you please do this by email. |
|
fyi @dotnet/jit-contrib a jit test failed here, but with no log captured. Console log: 'JIT.Methodical.a-dA-D' from job 815d9fa9-2c56-435c-8400-8b4dfb82a69f workitem e007438e-7141-4761-ba97-987e1412c1ad (windows.10.arm64v8.open) executed on machine DDARM64-179 |
lewing
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #60854 to release/6.0
/cc @lambdageek @rolfbjarne
Customer Impact
Allows applications targeting MacCatalyst to use APIs defined in terms of the
nfloattype. Additionally allows the definition ofnfloatto be in theObjCRuntimenamespace.Testing
CI and manual testing
Risk
Low