Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some VN refactoring #61034

Merged
merged 5 commits into from
Nov 2, 2021
Merged

Some VN refactoring #61034

merged 5 commits into from
Nov 2, 2021

Commits on Oct 30, 2021

  1. Remove "block" from VNApplySelectorsAssign 

    It was unused and all the callers passed the current block anyway.

Also some renaming to make Assign and AssignTypeCoerce methods consistent.
    @SingleAccretion
    SingleAccretion committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    a8e6979 View commit details
    Browse the repository at this point in the history

  2. Improve the readability of VNForMapStore 

    By naming parameters properly.
    @SingleAccretion
    SingleAccretion committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    149384b View commit details
    Browse the repository at this point in the history

  3. Improve the readability of VNForMapSelect 

    By naming parameters properly.
    @SingleAccretion
    SingleAccretion committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    4e51542 View commit details
    Browse the repository at this point in the history

  4. Pull ASG numbering out of fgValueNumberTree 

    In my upcoming substantive changes to this code the unreasonable level
of nesting started to significantly degrade the readability of code.

So, move it out of the main numbering function. The result is still
pretty huge and could be split up further, but this will do for now.
    @SingleAccretion
    SingleAccretion committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    d13bbc6 View commit details
    Browse the repository at this point in the history

  5. Refactor VNApplySelectors 

    Make it use a loop instead of recursion.

Rename parameters to match the "Assign" variants.

Add standard header comments.
    @SingleAccretion
    SingleAccretion committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    cc7838d View commit details
    Browse the repository at this point in the history