Add TFM and version support query to marshaller interface. #61064
Conversation
If any marshaller fails to support the current tfm version, fallback to using the built-in DllImport attribute.
AaronRobinsonMSFT
added
area-System.Runtime.InteropServices
source-generator
There was a problem hiding this comment.
The approach for checking supportability based on TFM works great for any out-of-band projects and any external customers, but still might cause issues with solving the following item on our list of features to productize:
Enable DllImportGenerator by default for all source projects instead of just NETCoreApp with specific references (closer to an in-box generator experience)
One option to solve this problem would be to just say "we'll enable the generator for all source projects and if someone adds a stub that needs a missing type, we'll the dotnet/runtime dev will see an error message about a type that's not available and they'll have to add a reference themselves". Given how rare this will likely be (maybe once in a release cycle max), I think this could be a reasonable solution if we add something in the docs about it.
Can you elaborate on why this would be an issue? The source generator is restricted to using public APIs only — similar to CrossGen2. Is there an example when this would fail? |
|
The problem would be when we're in the product since assemblies in the product reference a subset of the ref assemblies. For example, we added a direct reference to As of today, every assembly with P/Invokes in dotnet/runtime references the assemblies needed, but that isn't guaranteed to be the case if someone adds a new assembly in the repo. |
|
I think we should add:
|
…allers are supported on the target framework. Update compatibility document with fallback support.
| TestUtils.AssertPreSourceGeneratorCompilation(comp); | ||
|
|
||
| var newComp = TestUtils.RunGenerators( | ||
| comp, | ||
| new DllImportGeneratorOptionsProvider(useMarshalType: false, generateForwarders: true), |
There was a problem hiding this comment.
You gon rid of the test for the GenerateForwarders option?
There was a problem hiding this comment.
Yeah. Is this something we want to validate?
src/libraries/System.Runtime.InteropServices/tests/DllImportGenerator.UnitTests/TestUtils.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Elinor Fung <elfung@microsoft.com>
ghost
locked as resolved and limited conversation to collaborators
Fixes #60662
If any marshaller fails to support the current tfm version, fallback to using the built-in
DllImportattribute.This logic permits using the source generator for any .NET TFM and will gracefully "fallback" to only support platforms that can consume the generated source.
/cc @jkoritzinsky @elinor-fung @stephentoub @eerhardt