Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][debugger] Fix evaluation of a static class attribute; using current namespace for evaluation #61252

Merged
merged 24 commits into from
Nov 17, 2021
Merged

[wasm][debugger] Fix evaluation of a static class attribute; using current namespace for evaluation #61252

merged 24 commits into from
Nov 17, 2021

Conversation

ilonatommy
Copy link
Member

No description provided.

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels Nov 5, 2021
@ilonatommy ilonatommy self-assigned this Nov 5, 2021
@ghost
Copy link

ghost commented Nov 5, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-Debugger-mono
Milestone: -

@ilonatommy ilonatommy changed the title [wasm][debugger] Fix evaluation of a static class attribute [wasm][debugger] Fix evaluation of a static class attribute; using current namespace for evaluation Nov 8, 2021
@ilonatommy ilonatommy marked this pull request as ready for review November 8, 2021 11:25
@ilonatommy ilonatommy requested review from thaystg and radical and removed request for marek-safar November 8, 2021 11:25
@thaystg
Copy link
Member

thaystg commented Nov 9, 2021

@lewing do you want to backport this to net6?

radical
radical requested changes Nov 9, 2021
View reviewed changes
Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. I just have some questions, and suggestions.

src/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs Show resolved Hide resolved
src/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs Show resolved Hide resolved
src/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs Outdated Show resolved Hide resolved
src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated Show resolved Hide resolved
src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated Show resolved Hide resolved
src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated Show resolved Hide resolved
src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated Show resolved Hide resolved
src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated Show resolved Hide resolved
src/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs Show resolved Hide resolved
src/mono/wasm/debugger/DebuggerTestSuite/EvaluateOnCallFrameTests.cs Outdated Show resolved Hide resolved
radical
radical requested changes Nov 13, 2021
View reviewed changes
src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated Show resolved Hide resolved
src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated Show resolved Hide resolved
src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated Show resolved Hide resolved
src/mono/wasm/debugger/tests/debugger-test/debugger-evaluate-test.cs Outdated Show resolved Hide resolved
src/mono/wasm/debugger/DebuggerTestSuite/EvaluateOnCallFrameTests.cs Outdated Show resolved Hide resolved
src/mono/wasm/debugger/DebuggerTestSuite/EvaluateOnCallFrameTests.cs Outdated Show resolved Hide resolved
src/mono/wasm/debugger/DebuggerTestSuite/EvaluateOnCallFrameTests.cs Outdated Show resolved Hide resolved
src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs Outdated Show resolved Hide resolved
src/mono/wasm/debugger/DebuggerTestSuite/EvaluateOnCallFrameTests.cs Outdated Show resolved Hide resolved
@radical
Copy link
Member

radical commented Nov 13, 2021

Reading the code I noticed some cases that were not being handled, so I made some changes, which can go in a separate PR, and is based on this one. d020d36

@ilonatommy ilonatommy requested a review from radical November 15, 2021 09:14
@ilonatommy ilonatommy mentioned this pull request Nov 15, 2021
Closed
@ilonatommy ilonatommy requested a review from radical November 16, 2021 08:28
@ilonatommy ilonatommy mentioned this pull request Nov 16, 2021
Merged
radical
radical approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job 👍

@ilonatommy ilonatommy merged commit 10e107d into dotnet:main Nov 17, 2021
@ilonatommy ilonatommy deleted the add-static-attribute-support branch November 18, 2021 09:31
@AndyAyersMS AndyAyersMS mentioned this pull request Nov 22, 2021
Closed
This was referenced Nov 29, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thaystg thaystg thaystg approved these changes

@radical radical radical approved these changes

Assignees

@ilonatommy ilonatommy

Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilonatommy @thaystg @radical