-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm][debugger] Fix evaluation of a static class attribute; using current namespace for evaluation #61252
[wasm][debugger] Fix evaluation of a static class attribute; using current namespace for evaluation #61252
Conversation
Tagging subscribers to 'arch-wasm': @lewing Issue Detailsnull
|
src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs
Outdated
Show resolved
Hide resolved
…natommy/runtime into add-static-attribute-support
…ts that fail in Consol App.
src/mono/wasm/debugger/tests/debugger-test/debugger-evaluate-test.cs
Outdated
Show resolved
Hide resolved
@lewing do you want to backport this to net6? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good. I just have some questions, and suggestions.
src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs
Outdated
Show resolved
Hide resolved
src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs
Outdated
Show resolved
Hide resolved
src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs
Outdated
Show resolved
Hide resolved
src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs
Outdated
Show resolved
Hide resolved
src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs
Outdated
Show resolved
Hide resolved
src/mono/wasm/debugger/DebuggerTestSuite/EvaluateOnCallFrameTests.cs
Outdated
Show resolved
Hide resolved
…chance it will be located out of the current assembly.
src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs
Outdated
Show resolved
Hide resolved
src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs
Outdated
Show resolved
Hide resolved
src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs
Outdated
Show resolved
Hide resolved
src/mono/wasm/debugger/tests/debugger-test/debugger-evaluate-test.cs
Outdated
Show resolved
Hide resolved
src/mono/wasm/debugger/DebuggerTestSuite/EvaluateOnCallFrameTests.cs
Outdated
Show resolved
Hide resolved
src/mono/wasm/debugger/DebuggerTestSuite/EvaluateOnCallFrameTests.cs
Outdated
Show resolved
Hide resolved
src/mono/wasm/debugger/DebuggerTestSuite/EvaluateOnCallFrameTests.cs
Outdated
Show resolved
Hide resolved
src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs
Outdated
Show resolved
Hide resolved
src/mono/wasm/debugger/DebuggerTestSuite/EvaluateOnCallFrameTests.cs
Outdated
Show resolved
Hide resolved
Reading the code I noticed some cases that were not being handled, so I made some changes, which can go in a separate PR, and is based on this one. d020d36 |
src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs
Outdated
Show resolved
Hide resolved
src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs
Outdated
Show resolved
Hide resolved
src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good job 👍
No description provided.