Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][debugger] Fix evaluation of a static class attribute; using current namespace for evaluation #61252

Merged
merged 24 commits into from
Nov 17, 2021

Conversation

ilonatommy
Copy link
Member

No description provided.

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels Nov 5, 2021
@ilonatommy ilonatommy self-assigned this Nov 5, 2021
@ghost
Copy link

ghost commented Nov 5, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-Debugger-mono

Milestone: -

@ilonatommy ilonatommy changed the title [wasm][debugger] Fix evaluation of a static class attribute [wasm][debugger] Fix evaluation of a static class attribute; using current namespace for evaluation Nov 8, 2021
@ilonatommy ilonatommy marked this pull request as ready for review November 8, 2021 11:25
@ilonatommy ilonatommy requested review from thaystg and radical and removed request for marek-safar November 8, 2021 11:25
@thaystg
Copy link
Member

thaystg commented Nov 9, 2021

@lewing do you want to backport this to net6?

Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. I just have some questions, and suggestions.

@radical
Copy link
Member

radical commented Nov 13, 2021

Reading the code I noticed some cases that were not being handled, so I made some changes, which can go in a separate PR, and is based on this one. d020d36

Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants