Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPMI: Use diffed bytes for jit-analyze and print more info #61254

Merged
merged 1 commit into from
Nov 9, 2021

Commits on Nov 5, 2021

  1. SPMI: Use diffed bytes for jit-analyze and print more info

    Fix the misleading total bytes displayed when diffing with SPMI. If one
    of the JITs encountered missing data, the code bytes would not be
    included, while the other JIT could still have it included if it did not
    encounter missing data.
    
    Also add more information about missing SPMI data/successful replays
    printed. For replays that is useful to be able to gauge whether there is
    still ok coverage after a large change. For diffs, we print a warning
    for missing SPMI data that the diff summary may be misleading.
    
    Example for a successful replay:
        Clean SuperPMI replay (219868 contexts processed)
    
    Example for a replay with missing data:
        SuperPMI encountered missing data for 6 out of 27272 contexts
    
    Example warning printed:
        Warning: SuperPMI encountered missing data during the diff. The diff
        summary printed above may be misleading.
        Missing with base JIT: 0. Missing with diff JIT: 6. Total contexts:
        27272.
    jakobbotsch committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    20f394d View commit details
    Browse the repository at this point in the history