-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RIDs for MIRACLE LINUX 8 and 9 #61304
Conversation
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsWhenever we build dotnet RPMs for MIRACLE LINUX 8 (formerly Asianux Server 8) we have to This commit adds the following runtime IDs:
|
seems like you either miss some file @m10k or something else change. The failure is clearly related to your change and something is out of sync. |
@m10k you want to add it to this file as well: https://github.com/dotnet/runtime/blob/ec15b53daa184583ef978dfd59e30ca4791e9470/src/libraries/Microsoft.NETCore.Platforms/src/runtimeGroups.props Here is an example of a new platform addition: ec15b53 |
@safern Thanks for the feedback! I had already added Miracle Linux to As far as I can tell, the issue is that the RID graph needs to be rebuilt ( |
Ah I see, then you have to run the build with |
Whenever we build dotnet RPMs for MIRACLE LINUX 8 (formerly Asianux Server 8) we have to apply patches that add RIDs for MIRACLE LINUX. To streamline the build process, we would like to add our RIDs to the upstream sources, in the same way CentOS and other RHEL- derivatives do. This commit adds the following runtime IDs: - "miraclelinux" - "miraclelinux-x64" - "miraclelinux.8" - "miraclelinux.8-x64" - "miraclelinux.9" - "miraclelinux.9-x64"
Sorry, it took me quite a while to follow up.. I'm not sure but I have the feeling it was the newline at the end of the files that caused the tests to fail. Also, I took the opportunity to add ML9 as well. |
Seems OK to me (and CI is happy now). Any other comments, @wfurt? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Awesome, thank you everyone! |
Whenever we build dotnet RPMs for MIRACLE LINUX 8 (formerly Asianux Server 8) we have to
apply patches that add RIDs for MIRACLE LINUX. To streamline the build process, we would
like to add our RIDs to the upstream sources, in the same way CentOS and other RHEL-
derivatives do.
This commit adds the following runtime IDs: