Ensure MaxBy/MinBy return first element if all keys are null. #61364
+50
−36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the null handling semantics of the
Max
andMin
methods, the newMaxBy
andMinBy
methods have been designed to skip any elements yielding null keys. As a side-effect of the behavior, the methods will return the last element in a sequence if every key turns out to be null. While this does not produce any observable difference in theMax
andMin
methods, it does do so in theMaxBy
andMinBy
case. In fact it is inconsistent with how the same methods treat sequences returning identical non-null keys, where the first element is always favored.I do not believe this to be a breaking change, since our documentation provides no guarantee on what element will get returned in the event of a tie.
Fixes #61317.