[wasm][debugger] Correct the endian swapping and string implementation #61386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @thaystg Issue Detailsnull
|
lewing
changed the title
|
Tagging subscribers to 'arch-wasm': @lewing Issue Detailsnull
|
radical
reviewed
Nov 10, 2021
lewing
force-pushed
the
fix-sdb-formatting
branch
from
282179f to
7e05e8e
Compare
marek-safar
reviewed
Nov 10, 2021
lewing
force-pushed
the
fix-sdb-formatting
branch
from
80e294e to
d124824
Compare
thaystg
approved these changes
Nov 10, 2021
lewing
force-pushed
the
fix-sdb-formatting
branch
from
d124824 to
aac76ed
Compare
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A limited change fix WriteString and only byte swap when needed.