Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][debugger] Cleanup unused code. #61427

Merged
merged 1 commit into from
Nov 10, 2021
Merged

[wasm][debugger] Cleanup unused code. #61427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
using System.Threading;
using System.Threading.Tasks;
using Microsoft.Extensions.Logging;
using Newtonsoft.Json;
using Newtonsoft.Json.Linq;
using System.IO;
using Microsoft.CodeAnalysis.CSharp.Syntax;
Expand Down Expand Up @@ -227,8 +226,6 @@ public async Task<JObject> Resolve(ElementAccessExpressionSyntax elementAccess,
{
if (elementAccess.ArgumentList != null)
{
var commandParamsObj = new MemoryStream();
var commandParamsObjWriter = new MonoBinaryWriter(commandParamsObj);
foreach (var arg in elementAccess.ArgumentList.Arguments)
{
// e.g. x[1]
Expand Down
10 changes: 0 additions & 10 deletions src/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,11 @@
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Net;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.CodeAnalysis;
using Microsoft.Extensions.Logging;
using Newtonsoft.Json;
using Newtonsoft.Json.Linq;
using System.Net.Http;
using System.Text.RegularExpressions;
using Microsoft.CodeAnalysis.CSharp.Syntax;
using Microsoft.CodeAnalysis.CSharp;
Expand Down Expand Up @@ -1228,8 +1225,6 @@ public string ReplaceCommonClassNames(string className)

internal async Task<MonoBinaryReader> GetCAttrsFromType(SessionId sessionId, int objectId, int typeId, string attrName, CancellationToken token)
{
var invokeParams = new MemoryStream();
var invokeParamsWriter = new MonoBinaryWriter(invokeParams);
var commandParams = new MemoryStream();
var commandParamsWriter = new MonoBinaryWriter(commandParams);
commandParamsWriter.Write(typeId);
Expand Down Expand Up @@ -1287,11 +1282,6 @@ public async Task<string> GetValueFromDebuggerDisplayAttribute(SessionId session
if (getCAttrsRetReader == null)
return null;

var invokeParams = new MemoryStream();
var invokeParamsWriter = new MonoBinaryWriter(invokeParams);
invokeParamsWriter.Write((byte)ValueTypeId.Null);
invokeParamsWriter.Write((byte)0); //not used
invokeParamsWriter.Write(0); //not used
var parmCount = getCAttrsRetReader.ReadInt32();
var monoType = (ElementType) getCAttrsRetReader.ReadByte(); //MonoTypeEnum -> MONO_TYPE_STRING
if (monoType != ElementType.String)
Expand Down