Make more extensive use of lvaGetDesc() #61494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsIncluding the version with a I mostly replaced Made many resulting Removed unused Simplifies code, and centralizes assert checking. Added new This deletes many
|
|
/azp run runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Including the version with a `GenTreeLclVarCommon*` overload. I mostly replaced `&lvaTable[varNum]` and `lvaTable + varNum` expressions, leaving `lvaTable[varNum].xxx`. Made many resulting `varDsc*` const. Removed unused `lvaRefCount`. Simplifies code, and centralizes assert checking. Added new `lvaGetLclNum(LclVarDsc*)` function to map back to a varNum. This deletes many `noway_assert` in favor of the lvaGetDesc `assert`; I'm not worried about removing asserts from the Release build.
BruceForstall
force-pushed
the
UseLvaGetDesc
branch
from
47c845f to
ccf0b25
Compare
|
Rebased/re-pushed to see if the CI will be more compliant |
|
/azp run runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@dotnet/jit-contrib PTAL |
AndyAyersMS
approved these changes
Nov 24, 2021
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including the version with a
GenTreeLclVarCommon*overload.I mostly replaced
&lvaTable[varNum]andlvaTable + varNumexpressions, leaving
lvaTable[varNum].xxx.Made many resulting
varDsc*const.Removed unused
lvaRefCount.Simplifies code, and centralizes assert checking.
Added new
lvaGetLclNum(LclVarDsc*)function to map back to a varNum.This deletes many
noway_assertin favor of the lvaGetDescassert;I'm not worried about removing asserts from the Release build.
No asm diffs