-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parsing of ping error replies on raw sockets #61592
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #61465 Needs more testing. The ICMPv4 code path was tested locally, ICMPv6 was not tested at all.
|
LGTM
it would be great IMHO to add (outerloop) test. It would need to ignore cases when there is no answer and perhaps simply test that the address is not ANY.
|
Thanks for testing it. Apparently there's already similar test ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
thanks @filipnavara
Fixes #61465