Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a JsonWriterOptions.MaxDepth property #61608

Merged

Conversation

eiriktsarpalis
Copy link
Member

Add a MaxDepth property to JsonWriterOptions and ensures that JsonSerializerOptions.MaxDepth flows to Utf8JsonWriter in serialization.

Fix #44947.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Nov 15, 2021

Tagging subscribers to this area: @dotnet/area-system-text-json
See info in area-owners.md if you want to be subscribed.

Issue Details

Add a MaxDepth property to JsonWriterOptions and ensures that JsonSerializerOptions.MaxDepth flows to Utf8JsonWriter in serialization.

Fix #44947.

Author: eiriktsarpalis
Assignees: eiriktsarpalis
Labels:

area-System.Text.Json

Milestone: 7.0.0

@eiriktsarpalis eiriktsarpalis merged commit 4892e4f into dotnet:main Nov 22, 2021
eiriktsarpalis added a commit to eiriktsarpalis/runtime that referenced this pull request Nov 23, 2021
eiriktsarpalis added a commit that referenced this pull request Nov 23, 2021
)

* Replace occurrences of inlined throws with ThrowHelper calls

* remove NoInlining from ThrowHelpers.Throw* methods

* address feedback

* remove NoInlining attribute from local throw method

* Incorporate changes from #61608
@ghost ghost locked as resolved and limited conversation to collaborators Dec 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MaxDepth to JsonWriterOptions
2 participants