Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove race condition from DllImportGenerator build #61695

Merged
merged 6 commits into from
Nov 18, 2021
Merged

Remove race condition from DllImportGenerator build #61695

merged 6 commits into from
Nov 18, 2021

Commits on Nov 16, 2021

  1. Remove race condition from DllImportGenerator build 

    We had a race condition in the DllImportGenerator build due to the workaround implemented for Roslyn 4.0 RC1's new assembly loading scheme. RC2 has a fix that should work to enable us to remove the workaround.
    @jkoritzinsky
    jkoritzinsky committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    433fa32 View commit details
    Browse the repository at this point in the history

  2. Provide alternative solution that should still fix the race condition… 

    … (GetTargetPath doesn't touch any files, so it shouldn't race). We'll fix this with the real solution once we update to the RTM sdk
    @jkoritzinsky
    jkoritzinsky committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    c3356bc View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. Merge branch 'main' of github.com:dotnet/runtime into dllimportgenera… 

    …tor-race-fix
    @jkoritzinsky
    jkoritzinsky committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    a231548 View commit details
    Browse the repository at this point in the history

  2. Use regular project references and lay out the generator assemblies i… 

    …n a new per-project folder side-by-side to avoid race conditions.
    @jkoritzinsky
    jkoritzinsky committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    8f7918f View commit details
    Browse the repository at this point in the history

  3. Just use the repos handling for enabling DllImportGenerator to hook i… 

    …t up.
    @jkoritzinsky
    jkoritzinsky committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    b901a2b View commit details
    Browse the repository at this point in the history

  4. IncludeDllImportGeneratorSources should not control referencing the g… 

    …enerator itself.
    @jkoritzinsky
    jkoritzinsky committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    8bae81e View commit details
    Browse the repository at this point in the history