Convert System.Net.* over to GeneratedDllImport #61765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronRobinsonMSFT
added
area-System.Runtime.InteropServices
source-generator
# Conflicts: # src/libraries/Common/src/Interop/Windows/SspiCli/Interop.SSPI.cs
stephentoub
reviewed
Nov 18, 2021
| @@ -9,7 +9,9 @@ internal static partial class Interop | |||
| { | |||
| internal static partial class Advapi32 | |||
| { | |||
| [DllImport(Interop.Libraries.Advapi32, EntryPoint = "LsaLookupNames2", SetLastError = true, CharSet = CharSet.Unicode)] | |||
| #pragma warning disable DLLIMPORTGENANALYZER015 // Use 'GeneratedDllImportAttribute' instead of 'DllImportAttribute' to generate P/Invoke marshalling code at compile time | |||
There was a problem hiding this comment.
Should we update the analyzer to not warn in these cases until they're fixed?
There was a problem hiding this comment.
Agree. Let me see if I can get that going in the next PR.
stephentoub
approved these changes
Nov 18, 2021
|
Failure in WASM leg is #44862 |
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @jkoritzinsky @elinor-fung