Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested static classes fix broken tests #61830

Closed
wants to merge 75 commits into from
Closed

Nested static classes fix broken tests #61830

wants to merge 75 commits into from

Conversation

ilonatommy
Copy link
Member

PR for Issue #61509.

ilonatommy and others added 30 commits November 5, 2021 11:57
@ilonatommy
Using current namespace as the default place to serach for the resolv…
fab24e5 
…ed class.
@ilonatommy
Add tests for static class, static fields and pausing in async method.
66b56a7
@ilonatommy
Added tests for class evaluation.
782a107
@thaystg
Fixing support to the current namespace and adding tests for it
4119de3
@ilonatommy
Merge branch 'add-static-attribute-support' of https://github.com/ilo…
e275144 
…natommy/runtime into add-static-attribute-support
@ilonatommy
Assuing that we search within the current assembly first. Removed tes…
ee19014 
…ts that fail in Consol App.
@ilonatommy
Remove a test-duplicate that was not testing static class or static f…
89bdc49 
…ields.
@ilonatommy
Fixing indentation.
5ce0f57
@ilonatommy
Refixing indentation.
62d18b6
@ilonatommy
Refix indentations again.
ce177fd
@ilonatommy
Applied the advice about adding new blank lines.
cb32402
@ilonatommy
Changed the current assembly check.
ed2577e
@ilonatommy
Extracting the check from the loop. One time check is enough.
01f46d5
@ilonatommy
Simplifying multiple test cases into one call.
d14367d
@ilonatommy
Using local function as per review suggestion.
8a82380
@ilonatommy
Added test that was skipped by mistake.
7f24d47
@ilonatommy
Added looking for the namespace in all assemblies because there is a …
367c431 
…chance it will be located out of the current assembly.
@ilonatommy
Extracting value based on the current frame, not the top of stack loc…
55479c8 
…ation.
@ilonatommy
Test for classes evaluated from different frames.
5f5cdf6
@ilonatommy
Merge branch 'add-static-attribute-support' into add-nested-static-at…
4ba6b58 
…tribute-support
@ilonatommy
Tests for nested static classes.
c5d0153
@ilonatommy
Fix for nested static classes.
13a4a38
@ilonatommy
Fixed 9 tests from EvaluateOnCallFrame.
c5e1791
@ilonatommy
Fixing indentation and spaces.
7151177
@ilonatommy
Applied review comments for values evaluation.
5fc759e
@ilonatommy
Compressed two tests into one with MemberData.
3661c0e
@ilonatommy
Added test case of type without namespace (failing).
66ed5c2
@ilonatommy
Merge branch 'add-static-attribute-support' into add-nested-static-at…
382899f 
…tribute-support
@ilonatommy
Merge branch 'add-nested-static-attribute-support' into nested-static…
4c3afed 
…-classes-fix-broken-tests
@ilonatommy
Addressed Ankit advices from the review.
136f69a
ilonatommy and others added 23 commits November 18, 2021 09:32
@ilonatommy
Tests for nested static classes.
5f88089
@ilonatommy
Fix for nested static classes.
cdbe1c7
@ilonatommy
Fixing indentation and spaces.
cada76c
@ilonatommy
Applied review comments for values evaluation.
a840c24
@ilonatommy
Compressed two tests into one with MemberData.
59bdf92
@ilonatommy
Addressed Ankit advices from the review.
7e06d5a
@ilonatommy
Revert merged nested evaluation changes.
fd1f980
@ilonatommy
Incorporate Ankit's changes from d020d36.
35f33c9
@ilonatommy
Fix - when both valuesare null we should keep checking (e.g. for nest…
ad8cc3a 
…ed static classes).
@ilonatommy
Fix merge.
d3928d9
@ilonatommy
Cleanup after rebase.
c322461
@ilonatommy
Merge.
ecadc20
@ilonatommy
Merge branch 'main' into fix-static-attribute-support
15a6636
@ilonatommy
Added nested tests.
1169797
@ilonatommy
Fixed - works with and without namespace.
a096846
@ilonatommy
Merge branch 'add-nested-static-attribute-support' of https://github.…
421673c 
…com/ilonatommy/runtime into add-nested-static-attribute-support
@ilonatommy
Clean-up after rebasing with fix-static-attribute-support.
4b03b37
@ilonatommy
Fixed 9 tests from EvaluateOnCallFrame.
4b8ac74
@ilonatommy
Merge branch 'nested-static-classes-fix-broken-tests' of https://gith…
244546d 
…ub.com/ilonatommy/runtime into nested-static-classes-fix-broken-tests
@ilonatommy
Fixed 18 test types.
f736557
@ilonatommy
Fix test cases with spaces in the names, e.g. " this" evaluation.
67efb17
@ilonatommy @lewing
Update src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolv…
fac543d 
…er.cs

Co-authored-by: Larry Ewing <lewing@microsoft.com>
@ilonatommy
Merge branch 'add-nested-static-attribute-support' into nested-static…
b8e48c3 
…-classes-fix-broken-tests
@ghost
Copy link

ghost commented Nov 19, 2021

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

PR for Issue #61509.

Author: ilonatommy
Assignees: -
Labels:

area-Debugger-mono
Milestone: -

@ilonatommy ilonatommy added the arch-wasm WebAssembly architecture label Nov 19, 2021
@ilonatommy
Copy link
Member Author

Wrong destination branch.

@ilonatommy ilonatommy closed this Nov 19, 2021
@ilonatommy ilonatommy deleted the nested-static-classes-fix-broken-tests branch November 19, 2021 10:43
@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lewing lewing Awaiting requested review from lewing lewing will be requested when the pull request is marked ready for review lewing is a code owner

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara will be requested when the pull request is marked ready for review pavelsavara is a code owner

Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilonatommy @thaystg