-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0] Environment variable should override property for gcServer. #61969
Conversation
Add tests for the scenario.
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @dotnet/gc Issue DetailsBackport of #61950 to release/6.0 Customer ImpactThe ASP.NET Core project default settings define the GC to operate in Server mode. However, Some customers prefer Workstation. The recommended approach to address this is setting TestingA test was added for the impacted scenario. RiskLow. The change is permitting a niche scenario for the overriding of configuration properties. The only known consumer of this change is the tested GC scenario.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this is a regression should consider for 6.0.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. We should take for consideration for 6.0.x
Some clarifications on this:
|
Backport of #61950 to release/6.0
/cc @AaronRobinsonMSFT
Customer Impact
This is a regression from .NET 5 to .NET 6 (when we consolidated complus_ into dotnet_ environment variable naming). The change in behavior has been observed by multiple customers.
The ASP.NET Core project default settings define the GC to operate in Server mode. However, Some customers prefer Workstation. The recommended approach to address this is setting
DOTNET_gcServer=0
, which will override the default configuration property. Without this change the only workaround is to edit the projectruntimeconfig.json
file via a template or set an MSBuild property.Testing
A test was added for the impacted scenario.
Risk
Low. The change is permitting a niche scenario for the overriding of configuration properties. The only known consumer of this change is the tested GC scenario.