[release/6.0] Fix TimeSpan support in sourcegen #62191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
eiriktsarpalis,
layomia and
steveharter
as code owners
|
Tagging subscribers to this area: @dotnet/area-system-text-json Issue DetailsBackport of #62130 to release/6.0 /cc @eiriktsarpalis Customer ImpactTestingRisk
|
Closed
2 tasks
eiriktsarpalis
added
the
Servicing-consider
|
Servicing approved over email. |
eiriktsarpalis
added
Servicing-approved
stephentoub
approved these changes
Dec 1, 2021
safern
removed
the
NO-MERGE
|
Closing and reopening to get CI to run again. |
steveharter
reviewed
Dec 15, 2021
...ries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/RealWorldContextTests.cs
Show resolved
Hide resolved
steveharter
approved these changes
Dec 15, 2021
|
@ericstj @eiriktsarpalis do we need to address feedback? |
|
Sure, I can help with that since @eiriktsarpalis is out. |
|
Browser failures of S.T.J are an existing issue. #61524 I upgraded it to a tracking issue. |
|
Remaining failures are #58927 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #62130 to release/6.0
/cc @eiriktsarpalis
Customer Impact
This is a customer reported bug (#62082). System.Text.Json added support for
TimeSpanserialization (see #54186), however this was not extended to source generators. As a result, reflection and sourcegen serializers by default diverge in their handling of TimeSpan instances. While it is fairly straightforward for users to work around the issue, we believe this should be addressed in servicing sooner rather than later when we ship the next major release.Testing
Added integration tests verifying serialization and deserialization support for
TimeSpanin source generators.Risk
Low to minimal. Product code change simply flags
TimeSpanas a "known type" thereby defaulting generated code to the built-in converter.