Update overlapped field test to conflict on 32-bit arches #62308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lambdageek
added
area-VM-meta-mono
test-bug
On AOT the field's class may not have been fully inited yet. Related to dotnet#62311
|
@simonrozsival I changed from asserting, to just initializing the fields of the embedded struct, after all, since it looks like on AOT we use the cached size info and don't necessarily have the type initialized properly yet. |
|
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Waiting for more extensive validation here https://dev.azure.com/dnceng/public/_build/results?buildId=1495727&view=results |
|
Ok, the only failure on Which is being disabled in #62335 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62303
And related to #62311