Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: three fixes for OSR #62367

Merged
merged 1 commit into from
Dec 4, 2021
Merged

Conversation

AndyAyersMS
Copy link
Member

Found when trying to enable OSR by default and prospecting for arm64 support.

  • Explicitly initalize the OSR step variable.
  • Prevent fgOptimizeUncondBranchToSimpleCond from changing the scratch entry
    BB to have conditional flow.
  • Retain runtime supplied patchpoint info when cleaning up after an altjit failure.

Found when trying to enable OSR by default and prospecting for arm64 support.

* Explicitly initalize the OSR step variable.
* Prevent `fgOptimizeUncondBranchToSimpleCond` from changing the scratch entry
  BB to have conditional flow.
* Retain runtime supplied patchpoint info when cleaning up after an altjit failure.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 3, 2021
@ghost
Copy link

ghost commented Dec 3, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Found when trying to enable OSR by default and prospecting for arm64 support.

  • Explicitly initalize the OSR step variable.
  • Prevent fgOptimizeUncondBranchToSimpleCond from changing the scratch entry
    BB to have conditional flow.
  • Retain runtime supplied patchpoint info when cleaning up after an altjit failure.
Author: AndyAyersMS
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@AndyAyersMS
Copy link
Member Author

cc @dotnet/jit-contrib

Pulls in the two fixes from #61934 and one from a local fork where I'm working on arm64 support.

@AndyAyersMS AndyAyersMS merged commit 43b58c2 into dotnet:main Dec 4, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jan 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants