[release/6.0-maui] Backport MacCatalyst process start support #62520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Modify existing tests * Enable process start and kill on MacCatalyst * Typo * Temporarily enable ProcessTests for MacCatalyst * Temporarily enable ProcessTests for MacCatalyst - attempt 2 * Allow running Mac Catalyst builds in App Sandbox * Allow enabling app sandbox for the other Mac Catalyst sample * Add missing parameter to XCode project generator * Remove unnecessary MacCatalyst detection * Enable App Sandbox for Mac Catalyst tests * Create a separate test branch for App Sandbox * Remove the restriction to enable app sandbox just for Mac Catalyst apps * Do not throw PNSE for Mac Catalyst * Clean-up platform-specific conditions * Build correct Process implementation for MacCatalyst * Try to get more information from CI for further investigation of the failing build * Revert "Try to get more information from CI for further investigation of the failing build" This reverts commit fc63a37. * Add MacCatalyst target framework for System.Diagnostics.Process * Add supported platform annotations for Mac Catalyst * Fix annotations * Remove incorrectly placed attributes * Update attributes including the reference file * Change platform attributes * Generate app.entitlements in the BuildAppleAppBundles test build target * Revert "Generate app.entitlements in the BuildAppleAppBundles test build target" This reverts commit abbe224. * Enable AppSandbox when generating CMakeLists.txt for libraries tests * Try implementing a workaround for app sandbox mode * Fix app sandbox detection bug * Add explanation comment * Enable more tests for MacCatalyst * Add apple app builder input validation * Add Mac Catalyst w/ App Sandbox enabled to runtime-manual test pipeline * Enable networking in App Sandbox mode * Skip test which won't work on Mac Catalyst * Skip some tests in app sandbox mode * Update src/tasks/AppleAppBuilder/AppleAppBuilder.cs Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com> * Add a clarification comment for a networking entitlement * Simplify supported platform condition * Remove temporarily enabled test * Remove unnecessary attributes * Replace checking env variable with checking errno in libproc * Update docs * Remove unnecessary changes * Temporarily enable running System.Diagnostics.Process.Tests for this PR This reverts commit 02d370c. * Revert "Temporarily enable running System.Diagnostics.Process.Tests for this PR" This reverts commit dc72f0f. * Fix job suffix in runtime-manual * Remove attributes * Revert "Remove attributes" This reverts commit 704e9fa. * Try changing the order of attributes to please CI * Update ApiCompat baseline * ApiCompat step 1: remove all attributes for MaxWorkingSet setter * Revert "Update ApiCompat baseline" This reverts commit a2ad032. * Revert "ApiCompat step 1: remove all attributes for MaxWorkingSet setter" This reverts commit be72a3d. * Update ApiCompat baseline * Update ApiCompat baseline after pulling upstream main * Remove trailing whitespace Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/area-system-diagnostics-process Issue DetailsThis is a backport of #61507 to /cc @steveisok Customer impactTestingThe functionality is covered with unit tests. RiskLow.
|
* Run only relevat tests for app sandbox * Fix typo * Update src/libraries/tests.proj Co-authored-by: Jan Kotas <jkotas@microsoft.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com>
steveisok
approved these changes
Dec 9, 2021
akoeplinger
approved these changes
Dec 9, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #61507 to
release/6.0-maui/cc @steveisok
Customer impact
Implements #61295 and #61504.
Testing
The functionality is covered with unit tests.
Risk
Low.