[release/6.0] Making user secrets optional by default #62917
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue DetailsBackport of #62821 to release/6.0 /cc @maryamariyan Customer ImpactTestingRisk
|
maryamariyan
added
the
Servicing-consider
|
@maryamariyan - I think we need to add servicing changes here as well, so the See the docs and here is an example. |
ericstj
added
Servicing-approved
|
This was previously approved over email on 12/20 |
|
@ericstj @safern @carlossanlop - can someone merge this? |
|
I do not have permission to merge release changes with failing CI. @danmoseley? |
Is anyone actively looking into either fixing or disabling |
|
I'll put up a PR to port my fix for OpenDevices01 |
ghost
locked as resolved and limited conversation to collaborators
Backport of #62821 to release/6.0
/cc @maryamariyan
Customer Impact
Customer reported break from 5.0. Prior to 6.0, while using
IConfigurationBuilder.AddUserSecretsthe API was not flowing the optional flag. (assumed it was always optional even if it was set to false).This bugfix has caused a regression for when the user relies on the default value of optional flag (currently false).
In this regression fix, we are making sure when the default value for optional flag is used, that the behavior stays the same as it did before prior 6.0. We do that by flipping optional flag from false to true as default.
Please not there would be a breaking change from 6.0 to 6.0.2, but behavior remains the same as what it was in 5.0 and earlier.
Link to original pr fix.
Link to new pr fix.
Testing
Available in pr #62821
Risk
Low risk, because it would start matching behavior from 5.0 and before.
But there would be a breaking change from 6.0 to 6.0.2, but behavior remains the same as what it was in 5.0 and earlier.