Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][debugger] Missing test files #63148

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

thaystg
Copy link
Member

@thaystg thaystg commented Dec 27, 2021

Adding test files that were not added on release 6.0 by mistake.

@ghost
Copy link

ghost commented Dec 27, 2021

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Adding test files that were not added on release 6.0 by mistake.

Author: thaystg
Assignees: thaystg
Labels:

area-Debugger-mono

Milestone: -

@thaystg
Copy link
Member Author

thaystg commented Dec 27, 2021

@marek-safar Do I need to send an email to tactics for it?

@marek-safar marek-safar added the Servicing-consider Issue for next servicing release review label Dec 28, 2021
@marek-safar marek-safar added this to the 6.0.x milestone Dec 28, 2021
@marek-safar
Copy link
Contributor

@thaystg yes but you can reply to the original approval

@lambdageek
Copy link
Member

This is the project needed for this test https://github.com/dotnet/runtime/blob/release/6.0/src/mono/wasm/debugger/DebuggerTestSuite/Tests.cs#L864 InspectLocalsUsingClassFromLibraryUsingDebugTypeFull ?

@thaystg
Copy link
Member Author

thaystg commented Jan 4, 2022

This is the project needed for this test https://github.com/dotnet/runtime/blob/release/6.0/src/mono/wasm/debugger/DebuggerTestSuite/Tests.cs#L864 InspectLocalsUsingClassFromLibraryUsingDebugTypeFull ?

Yes

@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 4, 2022
@leecow leecow modified the milestones: 6.0.x, 6.0.2 Jan 4, 2022
@akoeplinger akoeplinger merged commit 6de5c5b into dotnet:release/6.0 Jan 14, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Feb 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Debugger-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants