Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded ifdefs #63160

Merged
merged 1 commit into from
Dec 28, 2021
Merged

Remove unneeded ifdefs #63160

merged 1 commit into from
Dec 28, 2021

Conversation

BruceForstall
Copy link
Member

Remove ifdefs for always-on values: ASSERTION_PROP,
LOCAL_ASSERTION_PROP, OPT_BOOL_OPS, LARGE_EXPSET,
REDUNDANT_LOAD.

@BruceForstall
Remove unneeded ifdefs
9edb32b 
Remove ifdefs for always-on values: ASSERTION_PROP,
LOCAL_ASSERTION_PROP, OPT_BOOL_OPS, LARGE_EXPSET,
REDUNDANT_LOAD.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 28, 2021
@ghost ghost assigned BruceForstall Dec 28, 2021
@ghost
Copy link

ghost commented Dec 28, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Remove ifdefs for always-on values: ASSERTION_PROP,
LOCAL_ASSERTION_PROP, OPT_BOOL_OPS, LARGE_EXPSET,
REDUNDANT_LOAD.

Author: BruceForstall
Assignees: BruceForstall
Labels:

area-CodeGen-coreclr
Milestone: -

@BruceForstall
Copy link
Member Author

@dotnet/jit-contrib PTAL

echesakov
echesakov approved these changes Dec 28, 2021
View reviewed changes
Copy link
Contributor

@echesakov echesakov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

No diffs with spmi? Forgot that I can look this myself in the CI:)

@BruceForstall BruceForstall merged commit 15e95fc into dotnet:main Dec 28, 2021
@BruceForstall BruceForstall deleted the RemoveUnneededIfdefs branch December 28, 2021 23:22
@ghost ghost locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@echesakov echesakov echesakov approved these changes

Assignees

@BruceForstall BruceForstall

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BruceForstall @echesakov