Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement System.Runtime.CompilerServices.DisabledRuntimeMarshallingAttribute on CoreCLR-family of runtimes/type systems #63320

Merged
merged 64 commits into from
Jan 21, 2022
Merged

Implement System.Runtime.CompilerServices.DisabledRuntimeMarshallingAttribute on CoreCLR-family of runtimes/type systems #63320

merged 64 commits into from
Jan 21, 2022

Commits on Dec 15, 2021

  1. Add the DisableRuntimeMarshallingAttribute to the build.

    @jkoritzinsky
    jkoritzinsky committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    95c08cf View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2021

  1. Add initial test suite

    @jkoritzinsky
    jkoritzinsky committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    225dea7 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2021

  1. Implement support in IL stubs for the "disabled runtime marshalling" … 

    …feature.
    @jkoritzinsky
    jkoritzinsky committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    7c85f02 View commit details
    Browse the repository at this point in the history

  2. Add testing for inlining IL stubs.

    @jkoritzinsky
    jkoritzinsky committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    132dc67 View commit details
    Browse the repository at this point in the history

  3. Block SetLastError and LCID support when DisableRuntimeMarshallingAtt… 

    …ribute is applied.
    @jkoritzinsky
    jkoritzinsky committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    70f2fab View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2022

  1. Bump NativeAOT-only R2R version header (missed previously)

    @jkoritzinsky
    jkoritzinsky committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    ae4f309 View commit details
    Browse the repository at this point in the history

  2. Implement support in crossgen2 and NativeAOT

    @jkoritzinsky
    jkoritzinsky committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    8681adf View commit details
    Browse the repository at this point in the history

  3. Clean up the test tree and update the tests to fail more reliably whe… 

    …n bugs are present.

Fix a bug that was uncovered when the tests were refactored.
    @jkoritzinsky
    jkoritzinsky committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    7700998 View commit details
    Browse the repository at this point in the history

  4. Fix NativeAOT and clean up crossgen2

    @jkoritzinsky
    jkoritzinsky committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    20094a2 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2022

  1. Add a test for NoPreserveSig with DisableRuntimeMarshalling

    @jkoritzinsky
    jkoritzinsky committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    f9f070f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:dotnet/runtime into disableruntimem… 

    …arshalling
    @jkoritzinsky
    jkoritzinsky committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    e0ee72e View commit details
    Browse the repository at this point in the history

  3. Assign hr in SUCCEEDED macro.

    @jkoritzinsky
    jkoritzinsky committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    694f5fb View commit details
    Browse the repository at this point in the history

  4. PR feedback.

    @jkoritzinsky
    jkoritzinsky committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    9ca4274 View commit details
    Browse the repository at this point in the history

  5. Block varargs in disabled marshalling mode.

    @jkoritzinsky
    jkoritzinsky committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    e84d87d View commit details
    Browse the repository at this point in the history

  6. Fix typo

    @jkoritzinsky
    jkoritzinsky committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    a4a8c99 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2022

  1. Block types that have a field that is auto-layout somewhere in their … 

    …layout.
    @jkoritzinsky
    jkoritzinsky committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    a0953a2 View commit details
    Browse the repository at this point in the history

  2. Fix typo

    @jkoritzinsky
    jkoritzinsky committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    118e21c View commit details
    Browse the repository at this point in the history

  3. Revert the AutoLayoutOrHasAutoLayoutFIeld check in the "marshalling e… 

    …nabled" case
    @jkoritzinsky
    jkoritzinsky committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    57c5553 View commit details
    Browse the repository at this point in the history

  4. Only set scope when it isn't null (it's null for some cases).

    @jkoritzinsky
    jkoritzinsky committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    8c7efa3 View commit details
    Browse the repository at this point in the history

  5. Fix narrowing conversion failure.

    @jkoritzinsky
    jkoritzinsky committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    ce914dc View commit details
    Browse the repository at this point in the history

  6. First pass simple implementation in Mono

    @jkoritzinsky
    jkoritzinsky committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    e72845f View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2022

  1. Fix assert to still work for the built-in marshalling system

    @jkoritzinsky
    jkoritzinsky committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    bcfa307 View commit details
    Browse the repository at this point in the history

  2. S_FALSE is a thing

    @jkoritzinsky
    jkoritzinsky committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    abf48cb View commit details
    Browse the repository at this point in the history

  3. Fix type load failures caused by eager type handle loading.

    @jkoritzinsky
    jkoritzinsky committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    517833f View commit details
    Browse the repository at this point in the history

  4. Get MethodILScope from the calling method when available (this covers… 

    … all cases where we need it)
    @jkoritzinsky
    jkoritzinsky committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    8eee013 View commit details
    Browse the repository at this point in the history

  5. Add const modifier.

    @jkoritzinsky
    jkoritzinsky committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    9d58b3f View commit details
    Browse the repository at this point in the history

  6. Try 2 to fix const modifiers

    @jkoritzinsky
    jkoritzinsky committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    9bb7a62 View commit details
    Browse the repository at this point in the history

  7. Fix compilation of NativeAOT jitinterface

    @jkoritzinsky
    jkoritzinsky committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    887e20a View commit details
    Browse the repository at this point in the history

  8. Fix type lookup in Mono

    @jkoritzinsky
    jkoritzinsky committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    a8671be View commit details
    Browse the repository at this point in the history

  9. Merge branch 'disableruntimemarshalling' of github.com:jkoritzinsky/r… 

    …untime into disableruntimemarshalling
    @jkoritzinsky
    jkoritzinsky committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    e1d26fc View commit details
    Browse the repository at this point in the history

  10. Use try_get model for getting the attribute type in the case of failu… 

    …re. Fix mono implementation for looking up the attribute.
    @jkoritzinsky
    jkoritzinsky committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    f928557 View commit details
    Browse the repository at this point in the history

  11. Handle void and generic instantiations

    @jkoritzinsky
    jkoritzinsky committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    754ffaf View commit details
    Browse the repository at this point in the history

  12. Update auto-layout check to check recursively in layout.

    @jkoritzinsky
    jkoritzinsky committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    149ba9f View commit details
    Browse the repository at this point in the history

  13. Enhance test suite with more tests for UnmanagedCallersOnly, generics… 

    …, and the like. Fix AutoLayout test.
    @jkoritzinsky
    jkoritzinsky committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    82c0086 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2022

  1. Fix IL and a few typos

    @jkoritzinsky
    jkoritzinsky committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    d759243 View commit details
    Browse the repository at this point in the history

  2. Set a value in the padding for easier debugging.

    @jkoritzinsky
    jkoritzinsky committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    4218e1d View commit details
    Browse the repository at this point in the history

  3. Create sig->marshalling_disabled to track when marshalling is disable… 

    …d, which is separate from the concept of "is this signature a P/Invoke"
    @jkoritzinsky
    jkoritzinsky committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    54dc419 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2022

  1. Fix running test suite on Mono + Mini JIT

    @jkoritzinsky
    jkoritzinsky committed Jan 8, 2022
    Configuration menu
    Copy the full SHA
    5ae53f8 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2022

  1. Fix recursive type load failure by only checking the "has auto-layout… 

    … or field with auto-layout" for value types.
    @jkoritzinsky
    jkoritzinsky committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    41a4474 View commit details
    Browse the repository at this point in the history

  2. Fix mono windows build.

    @jkoritzinsky
    jkoritzinsky committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    adb46bc View commit details
    Browse the repository at this point in the history

  3. Feedback from Michal.

    @jkoritzinsky
    jkoritzinsky committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    1b26307 View commit details
    Browse the repository at this point in the history

  4. Fix bug in EcmaAssembly.HasAssemblyCustomAttribute

    @jkoritzinsky
    jkoritzinsky committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    5c70dc2 View commit details
    Browse the repository at this point in the history

  5. Make the runtime flavor check in the wrapper generator case-invariant

    @jkoritzinsky
    jkoritzinsky committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    b8588dc View commit details
    Browse the repository at this point in the history

  6. Use helper method since various different platforms/configurations th… 

    …row different exceptions for these scenarios.
    @jkoritzinsky
    jkoritzinsky committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    f2d91ff View commit details
    Browse the repository at this point in the history

  7. Fix AutoLayout test refactor and use a dummy value for the padding fi… 

    …eld in both enabled and disabled scenarios.
    @jkoritzinsky
    jkoritzinsky committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    f2f773d View commit details
    Browse the repository at this point in the history

  8. Add an explicit test for using enums as they're a little weird and ne… 

    …eded some special-casing.
    @jkoritzinsky
    jkoritzinsky committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    46c12bb View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. Fix build-time test filtering in xunit wrapper generator.

    @jkoritzinsky
    jkoritzinsky committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    4c49207 View commit details
    Browse the repository at this point in the history

  2. Fix some x86-specific issues

    @jkoritzinsky
    jkoritzinsky committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    a660f12 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'disableruntimemarshalling' of E:/home/jekoritz/runtime … 

    …into disableruntimemarshalling
    @jkoritzinsky
    jkoritzinsky committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    f0c86ec View commit details
    Browse the repository at this point in the history

  4. Add a nice big comment block.

    @jkoritzinsky
    jkoritzinsky committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    57c482b View commit details
    Browse the repository at this point in the history

  5. Fix x86

    @jkoritzinsky
    jkoritzinsky committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    d0e12db View commit details
    Browse the repository at this point in the history

  6. Refactor tests so we can skip one on Mono since Char->char lossy conv… 

    …ersion is not supported.
    @jkoritzinsky
    jkoritzinsky committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    7524223 View commit details
    Browse the repository at this point in the history

  7. Disable test in issues.targets until an alternative solution is reached.

    @jkoritzinsky
    jkoritzinsky committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    b62fd52 View commit details
    Browse the repository at this point in the history

  8. Add another SkipOnMono attribute in the "Enabled" test suite.

    @jkoritzinsky
    jkoritzinsky committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    e3b7686 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'disableruntimemarshalling' of github.com:jkoritzinsky/r… 

    …untime into disableruntimemarshalling
    @jkoritzinsky
    jkoritzinsky committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    2ecd865 View commit details
    Browse the repository at this point in the history

  10. Apply UnmangedFunctionPointerAttribute to help hint to the Mono LLVM … 

    …AOT compiler to compile the managed->native thunks at aot-time
    @jkoritzinsky
    jkoritzinsky committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    7b0f9b2 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. Unify on "runtime marshalling" terminology

    @jkoritzinsky
    jkoritzinsky committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    3122f76 View commit details
    Browse the repository at this point in the history

  2. Clean up unused usings.

    @jkoritzinsky
    jkoritzinsky committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    0d1f54e View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2022

  1. Address Jan's feedback except for applying the attribute to CoreLib.

    @jkoritzinsky
    jkoritzinsky committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    6a08e87 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2022

  1. PR feedback.

    @jkoritzinsky
    jkoritzinsky committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    9e0fc41 View commit details
    Browse the repository at this point in the history

  2. Mono throws an InvalidProgramException for varargs

    @jkoritzinsky
    jkoritzinsky committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    0896e44 View commit details
    Browse the repository at this point in the history

  3. Fix copy-paste issue.

    @jkoritzinsky
    jkoritzinsky committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    3609c82 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2022

  1. Make sure we use the P/Invoke's Module and not the caller's module wh… 

    …en deciding if runtime marshalling is enabled for a varargs P/Invoke call.
    @jkoritzinsky
    jkoritzinsky committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    74b0f61 View commit details
    Browse the repository at this point in the history

  2. Handle how LLVM AOT reports the failure to handle varargs (EEE)

    @jkoritzinsky
    jkoritzinsky committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    f496d66 View commit details
    Browse the repository at this point in the history