Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split sendtohelixhelp.proj to extract wasm, and mobile bits to separate files. #63373

Merged
merged 9 commits into from
Jan 15, 2022
Merged

Split sendtohelixhelp.proj to extract wasm, and mobile bits to separate files. #63373

merged 9 commits into from
Jan 15, 2022

Commits on Jan 10, 2022

  1. Extract wasm, and mobile specific bits from sendtohelixhelp.proj into 

    .. separate files, so they can be easier to manage.

- the platform specific properties are set in their respective files
  (for eg `sendtohelixhelp-wasm.proj`)
- a new target `BuildHelixCommand` is extracted from
  `BuildHelixWorkItems`, which runs first
  - and essentially builds `@(HelixCommand)`

- Platform specific targets can run via
  `$(BuildHelixWorkItemsDependsOn)`
  - which then add any "special" helix work items

- `BuildHelixWorkItems` in the main file supports adding for the regular
  case, which is controlled by `$(EnableDefaultBuildHelixWorkItems)`.
    @radical
    radical committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    a4a3356 View commit details
    Browse the repository at this point in the history

  2. [wasm] Enable samples that were fixed in an earlier PR 

    Fixes dotnet#52137
    @radical
    radical committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    44b4932 View commit details
    Browse the repository at this point in the history

  3. [wasm] Update condition for preparing samples for helix

    @radical
    radical committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    1dccd12 View commit details
    Browse the repository at this point in the history

  4. cleanup

    @radical
    radical committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    6f5ae4d View commit details
    Browse the repository at this point in the history

  5. address review feedback

    @radical
    radical committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    2fac92b View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/main' into split-helix-2

    @radical
    radical committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    523e54a View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2022

  1. Merge remote-tracking branch 'origin/main' into split-helix-2

    @radical
    radical committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    d8e836c View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. Merge remote-tracking branch 'origin/main' into split-helix-2

    @radical
    radical committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    5a7cd5e View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into split-helix-2

    @radical
    radical committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    3676a0e View commit details
    Browse the repository at this point in the history