Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the MacOS remote unwinder for VS4Mac #63378

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Conversation

mikem8361
Copy link
Member

The wrong module was being passed to the remote unwinder because the load bias for shared modules was being calculated incorrectly. This PR undo's the regression from PR #60995.

#63309

The wrong module was being passed to the remote unwinder because the load bias for shared modules
was being calculated incorrectly.
@ghost
Copy link

ghost commented Jan 5, 2022

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

The wrong module was being passed to the remote unwinder because the load bias for shared modules was being calculated incorrectly. This PR undo's the regression from PR #60995.

#63309

Author: mikem8361
Assignees: mikem8361
Labels:

area-Diagnostics-coreclr

Milestone: -

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mikem8361 mikem8361 merged commit 311ecfe into dotnet:main Jan 5, 2022
@mikem8361 mikem8361 deleted the fixunwind branch January 5, 2022 18:39
@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants