[release/6.0] Include properties on records for (de)serialization in source-gen #63454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
eiriktsarpalis,
layomia and
steveharter
as code owners
|
Tagging subscribers to this area: @dotnet/area-system-text-json |
steveharter
approved these changes
Jan 7, 2022
layomia
added
Servicing-approved
|
Approved by Tactics via email. |
|
Test failures #58927 and the ports fixed issue. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #62668 to release/6.0
Customer Impact
Fixes customer reported JSON source generation issues (#62374, #61772) where members of records defined in external assemblies are not included for (de)serialization, causing silent data loss. Multiple users reported this which suggests that it is not an edge-case scenario. There are currently no issues with records defined in the same assembly that invokes the source generator.
Testing
Tests for the customer scenarios have been added, along with variants to ensure that this is a complete fix.
Risk
Low. The code change is small and scoped to the issue. Changes introduced only affect usage of the source generator, and not System.Text.Json in general.