[release/6.0] Make delegates unsupported by JsonSerializer #63514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
eiriktsarpalis,
layomia and
steveharter
as code owners
|
Tagging subscribers to this area: @dotnet/area-system-text-json |
This was referenced Jan 10, 2022
layomia
added
Servicing-approved
|
Approved by tactics via email. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #63495 to release/6.0
Customer Impact
Fixes customer reported JSON source gen issue #62354. The code generated when delegate types were encountered in user object graphs was invalid, causing compilation failures in user apps. This change explicitly treats the types as unsupported by both reflection and source-gen serializers, which avoids invalid code being generated for the types. This is not a breaking change since the reflection serializer was already throwing exceptions when handling these types.
Users cannot currently workaround the bug, even with
[JsonIgnore](aside from sticking with the reflection serialzer). A fix is ideal to unblock users with such object graphs.Testing
Appropriate tests were added for the scenario.
Risk
Very low. Change is very small and scoped to the issue. Added tests.