Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for CMAKE_C_COMPILER_ID not CXX #64226

Merged
merged 5 commits into from
Jan 28, 2022
Merged

Check for CMAKE_C_COMPILER_ID not CXX #64226

merged 5 commits into from
Jan 28, 2022

Commits on Jan 24, 2022

  1. Check for CMAKE_C_COMPILER_ID not CXX 

    In some cases, CMAKE_CXX_COMPILER_ID might not be populated,
which causes the toolchaine prefix checks to be ignored, which
causes the build to look for `ranlib` not `llvm-ranlib`, which
causes it to use XCode ranlib instead of Android NDK ranlib for
builds, which doesn't work.

Hopefully (we'll see what CI says) this doesn't regress other builds.

Closes: dotnet#55412
    @directhex
    directhex committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    ee1309f View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2022

  1. Update eng/native/configuretools.cmake 

    Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
    @directhex @am11
    directhex and am11 authored Jan 25, 2022
    Configuration menu
    Copy the full SHA
    baca797 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into cmake-toolchain-suppo… 

    …rt-is-moderately-cursed
    @directhex
    directhex committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    75ae939 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into cmake-toolchain-suppo… 

    …rt-is-moderately-cursed
    @directhex
    directhex committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    3288046 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2022

  1. Use llvm-objcopy, not GNU, on Android 

    It's available in r21 (which we use today) and works for r23
(which has no GNU objcopy any more and breaks without this change)
    @directhex
    directhex committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    799dfdc View commit details
    Browse the repository at this point in the history