[wasm] Cancel pending ReadableStream on Dispose or cancelationToken #64285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add unit test for the scenario
pavelsavara
added
arch-wasm
|
Tagging subscribers to this area: @dotnet/ncl Issue Details
|
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kg
reviewed
Jan 25, 2022
src/libraries/Common/tests/System/Net/Http/ResponseStreamTest.cs
Outdated
Show resolved
Hide resolved
|
One area- label only please, for labeler bot .. |
halter73
reviewed
Jan 25, 2022
src/libraries/System.Net.Http/src/System/Net/Http/BrowserHttpHandler/BrowserHttpHandler.cs
Outdated
Show resolved
Hide resolved
- fixed few cancelation issues
maraf
reviewed
Jan 27, 2022
src/libraries/System.Net.Http/src/System/Net/Http/BrowserHttpHandler/BrowserHttpHandler.cs
Show resolved
Hide resolved
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pavelsavara
changed the title
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
marek-safar
reviewed
Jan 27, 2022
src/libraries/Common/tests/System/Net/Http/GenericLoopbackServer.cs
Outdated
Show resolved
Hide resolved
marek-safar
reviewed
Jan 27, 2022
...braries/Common/tests/System/Net/Prerequisites/RemoteLoopServer/Handlers/RemoteLoopHandler.cs
Outdated
Show resolved
Hide resolved
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
maraf
approved these changes
Jan 28, 2022
src/libraries/Common/tests/System/Net/Http/GenericLoopbackServer.cs
Outdated
Show resolved
Hide resolved
lewing
reviewed
Jan 28, 2022
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Cancellation.cs
Outdated
Show resolved
Hide resolved
…st.Cancellation.cs
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
We've had another customer report of this in net6 should we consider servicing it? |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReadableStream.cancelon cancelationToken ofWasmHttpReadStream.ReadAsyncAbortController.abortwhen disposingWasmFetchResponseandWasmHttpReadStreamSocketsHttpHandler_HttpClientHandler_Http11_Cancellation_Testtests for Browser targetWaitForCloseto theLoopbackServerRemoteLoopHandlerFixes #64225