JIT: fix x86 codegen issue #64476
Merged
JIT: fix x86 codegen issue #64476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were not calling `genProduceReg` in one case, leading to a missing def and liveness assert. Normally this would have been a temp assign followed by a copy to a local; evidently we don't track liveness for temps and so don't notice the missing def, and the subsequent copy defs the local and all seems well. Forward sub gets rid of the copy and exposes the issue under jit stress.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsWe were not calling Forward sub gets rid of the copy and exposes the issue under jit stress.
|
BruceForstall
approved these changes
Jan 28, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not calling
genProduceRegin one case, leading to a missingdef and liveness assert. Normally this would have been a temp assign
followed by a copy to a local; evidently we don't track liveness for
temps and so don't notice the missing def, and the subsequent copy defs
the local and all seems well.
Forward sub gets rid of the copy and exposes the issue under jit stress.