Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable some PerformanceCounter tests on more platforms #64633

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Feb 1, 2022

These tests were disabled in #61101 due to random failures like #60933. We are continuing to see these failures on x86 as well.

I only see one of these failing on x86, but it indicates to me that the same failure mode that we were hitting in these other tests is not specific to x64.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned sbomer Feb 1, 2022
@sbomer sbomer requested review from krwq and ericstj February 1, 2022 17:23
These tests were disabled in dotnet#61101
due to random failures like dotnet#60933.

We are continuing to see these failures on x86 as well.
@sbomer
Copy link
Member Author

sbomer commented Feb 1, 2022

Failures are unrelated and look like emscripten-core/emscripten#16164.

@sbomer sbomer requested a review from agocke February 1, 2022 20:25
@jkotas jkotas merged commit 6fc2548 into dotnet:main Feb 1, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Mar 4, 2022
@sbomer sbomer deleted the disablePerfCounterTests branch November 3, 2023 18:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants