-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests][mobile] Enable diagnostic_tracing for iOS runtime tests #64952
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-staging |
Azure Pipelines successfully started running 1 pipeline(s). |
c86424c
to
cf55803
Compare
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
1723de7
to
dd06be7
Compare
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
If the diagnostics tests on extra platforms lane are good, then I'll revert the code that reenables the ios runtime tests as there are still problematic tests there. |
Checked in the CI runs, all 10 of the tests mentioned in the description are passing on runtime-staging https://helix.dot.net/api/jobs/5d44bace-4d99-4cde-9ac8-eb29f4997b73/workitems/PayloadGroup0?api-version=2019-06-17 The other failures seem unrelated. |
This reverts commit dd06be7.
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
This PR looks to stand-up diagnostics tests for iOS. Diagnostics runtime components have been made compatible for mobile platforms, and here, they will be tested and integrated.
This is the iOS parallel of #60879
The following are changes made:
Includes diagnostics_tracing runtime components in BuildiOSApp
With a goal of emulating the diagnostics tracing tests on mono desktop, the following tests now pass locally.
eventlistener
eventlistener
eventcounter
eventcounter
pollingcounter
regression-46938
regression-25709
incrementingpollingcounter
runtimecounters
incrementingeventcounter
gh53564
eventactivityidcontrol
eventactivityidcontrol