Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests][mobile] Enable diagnostic_tracing for iOS runtime tests #64952

Merged
merged 5 commits into from
Feb 14, 2022

Conversation

mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Feb 8, 2022

This PR looks to stand-up diagnostics tests for iOS. Diagnostics runtime components have been made compatible for mobile platforms, and here, they will be tested and integrated.

This is the iOS parallel of #60879

The following are changes made:
Includes diagnostics_tracing runtime components in BuildiOSApp

With a goal of emulating the diagnostics tracing tests on mono desktop, the following tests now pass locally.

eventlistener

eventlistener

eventcounter

eventcounter
pollingcounter
regression-46938
regression-25709
incrementingpollingcounter
runtimecounters
incrementingeventcounter
gh53564

eventactivityidcontrol

eventactivityidcontrol


@ghost ghost assigned mdh1418 Feb 8, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@mdh1418
Copy link
Member Author

mdh1418 commented Feb 8, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mdh1418
Copy link
Member Author

mdh1418 commented Feb 8, 2022

/azp run runtime-staging

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mdh1418 mdh1418 force-pushed the enable_ios_diagnostics_tests branch from c86424c to cf55803 Compare February 8, 2022 22:33
@mdh1418
Copy link
Member Author

mdh1418 commented Feb 9, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mdh1418
Copy link
Member Author

mdh1418 commented Feb 11, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mdh1418
Copy link
Member Author

mdh1418 commented Feb 11, 2022

If the diagnostics tests on extra platforms lane are good, then I'll revert the code that reenables the ios runtime tests as there are still problematic tests there.

@mdh1418
Copy link
Member Author

mdh1418 commented Feb 14, 2022

Checked in the CI runs, all 10 of the tests mentioned in the description are passing on runtime-staging https://helix.dot.net/api/jobs/5d44bace-4d99-4cde-9ac8-eb29f4997b73/workitems/PayloadGroup0?api-version=2019-06-17
Will revert the commit that re-enabled iOS runtime tests.

The other failures seem unrelated.

@mdh1418
Copy link
Member Author

mdh1418 commented Feb 14, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants